Skip to content

Added labels for addresses - #73

Open
CharliePlett wants to merge 2 commits into
OpenHistoricalMap:stagingfrom
CharliePlett:addresses
Open

Added labels for addresses#73
CharliePlett wants to merge 2 commits into
OpenHistoricalMap:stagingfrom
CharliePlett:addresses

Conversation

@CharliePlett

@CharliePlett CharliePlett commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Added labels for address nodes and building_addresses and appended address to building names. OpenHistoricalMap/issues#1353

@1ec5 1ec5 linked an issue Aug 1, 2026 that may be closed by this pull request
Comment thread historical/historical.json Outdated
"format",
["get", "name"],
{},
"\n",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the building has a house number but lacks a name, this newline shifts the house number down by a full line. The user would perceive a label at a different location, possibly on a different building.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was kind of thinking the same. Would you suggest keeping the number the same size as the name? Because I also feel like the label gets very tall when it's a longer name and wraps on 2 lines and then also the address on a third line. And then your translation text in the future.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I just realized what you actually commented. Yeah, I can fix that.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was kind of thinking the same. Would you suggest keeping the number the same size as the name? Because I also feel like the label gets very tall when it's a longer name and wraps on 2 lines and then also the address on a third line.

I think the subtitle text in #73 (comment) is less confusing than OpenHistoricalMap/issues#1353 (comment), particularly because a four-digit number in parentheses could easily be mistaken for a year.

If the house number makes the label too tall, I suppose we could nix the house number when there’s already a name. OSM Carto does that under the assumption that a named building is already sufficiently identifiable. Alternatively, we could shrink the building labels to match the POI labels. If so, I’d shrink the house numbers further still or italicize them to keep them distinct from the building names.

And then your translation text in the future.

The translation replaces the main text. The gloss we’re considering in OpenHistoricalMap/issues#799 would get appended to labels in some layers, particularly places, but not necessarily for something like buildings, since it could get pretty repetitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Historic style should label addresses

2 participants