Added islands and islets place names - #72
Open
CharliePlett wants to merge 1 commit into
Open
Conversation
1ec5
reviewed
Aug 10, 2026
| "text-size": ["interpolate", ["linear"], ["zoom"], 3, 4, 6, 7, 10, 10], | ||
| "symbol-avoid-edges": true, | ||
| "symbol-spacing": 25, | ||
| "text-font": ["OpenHistorical"], |
Member
There was a problem hiding this comment.
I think natural features tend to get italicized in this style. Let’s use OpenHistoricalMap Italic instead for both of these layers.
Comment on lines
+6747
to
+6749
| "minzoom": 12, | ||
| "maxzoom": 20, | ||
| "filter": ["in", ["get", "type"], ["literal", ["islet"]]], |
Member
There was a problem hiding this comment.
If I’m not mistaken, the only differences between the two layers are minzoom, filter, and text-size. Can we combine the two layers by filtering out islets at zoom levels 8 through 12 inside filter and varying some of the text-size zoom stops based on the type attribute? Let me know if this is unclear or you run into any problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added islands and islets to the main style for this issue OpenHistoricalMap/issues#1396
z9
z13
