Fix: don't drop requested OIDC scopes not listed in scopes_supported - #932
Merged
Conversation
…ovider's discovery
soxofaan
reviewed
Aug 13, 2026
soxofaan pointed out in review that keeping `_supported_scopes` around just for gating the "offline_access" refresh-token scope was similarly unnecessarily cautious as the intersection this PR already removes. Drop it entirely: "offline_access" is now always requested when a refresh token is desired, regardless of what the discovery document advertises. Open-EO#932 (review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / why
Fixes #930.
OidcProviderInfo.__init__was intersecting the scopes an openEO backend declares (e.g.api://<client-id>/openeo) against the discovery document'sscopes_supportedfield. Microsoft Entra ID always reports a fixed, tenant-widescopes_supported(openid,profile,email,offline_access) regardless of the app's actual custom scopes, so the intersection silently dropped the one scope needed to get a usable access token. No openEO backend behind Entra ID could be authenticated against.Per @soxofaan comment, this implements option 3 from the issue: stop filtering requested scopes against
scopes_supportedaltogether. It's only a RECOMMENDED, descriptive field per RFC 8414 §2Changes
openeo/rest/auth/oidc.py:OidcProviderInfonow requests{"openid"} | scopesdirectly, without intersecting againstscopes_supported. Theoffline_access-if-supported behavior for refresh tokens is unchanged.tests/rest/auth/test_oidc.py: added a regression test asserting a requested scope not present inscopes_supportedis preserved.CHANGELOG.md: entry underUnreleased / Fixed.Disclosure
This PR was drafted with the help of Claude Code, per
AGENTS.md.