Skip to content

Fix broken builds - #727

Open
mcarans wants to merge 4 commits into
OoliteProject:masterfrom
mcarans:master
Open

Fix broken builds#727
mcarans wants to merge 4 commits into
OoliteProject:masterfrom
mcarans:master

Conversation

@mcarans

@mcarans mcarans commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Fixes #728

@LW-archlinux Please let me know if this fixes the problem #722 (comment)

Ignore the failed flatpak build - there seems to be an outage of archive.mesa3d.org - see https://gitlab.freedesktop.org/freedesktop/freedesktop/-/work_items?show=eyJpaWQiOiIzODE1IiwiZnVsbF9wYXRoIjoiZnJlZWRlc2t0b3AvZnJlZWRlc2t0b3AiLCJpZCI6MTU1Njc5fQ%3D%3D

@mcarans mcarans mentioned this pull request Aug 24, 2026
@mcarans mcarans changed the title Fix broken Linux builds Fix broken builds Aug 24, 2026
@mcarans

mcarans commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

@phkb does this fix #728 (Default location for GNUstep has moved to %UserProfile% on Windows, ignores oolite.app\GNUstep)?

@phkb

phkb commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

It doesn't appear to. Still only looks at %UserProfile%\GNUstep, no matter what is in oolite.app\GNUstep

@mcarans

mcarans commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

@phkb ok I've now completely reverted the NSBundle changes in this PR. That should fix it. Please confirm.

@phkb

phkb commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Confirmed. Everything seems to work as expected now.

@mcarans

mcarans commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

@LW-archlinux this should fix the issue you had as it is a complete revert of the resource path stuff. Please confirm.

@LW-archlinux

Copy link
Copy Markdown

I created a local oolite-test-git package to ensure I was using the correct version.

Applying this PR to master 4472873 through that packages solves the issue .

FYI :
Opening log for Oolite version 1.93.1-207+dirty.2 by unknown (x86-64 test release) under Linux 7.1.9-arch1-2 at 2026-08-24 11:24:18 +0200.

So oolite build process from source does detect changes since the last tagged version .
Looks like all the work to improve versioning is paying off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default location for GNUstep has moved to %UserProfile% on Windows, ignores oolite.app\GNUstep

3 participants