Skip to content

chore(attribute): improve speed handling - #183

Merged
theEvilReaper merged 5 commits into
mainfrom
feature/slenderSpeedModifier
Aug 13, 2026
Merged

chore(attribute): improve speed handling#183
theEvilReaper merged 5 commits into
mainfrom
feature/slenderSpeedModifier

Conversation

@theEvilReaper

@theEvilReaper theEvilReaper commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Proposed changes

The current implementation modifies the base movement speed value directly, which can lead to unexpected speed variations. This pull request reworks the attribute handling to ensure more consistent behavior.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@theEvilReaper theEvilReaper self-assigned this Aug 13, 2026
@theEvilReaper theEvilReaper added the area: game Everything related to the the game module label Aug 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Test results

231 files  231 suites   1m 51s ⏱️
272 tests 267 ✅  5 💤 0 ❌
819 runs  804 ✅ 15 💤 0 ❌

Results for commit a4add9f.

@theEvilReaper
theEvilReaper merged commit 2743f68 into main Aug 13, 2026
8 checks passed
@theEvilReaper
theEvilReaper deleted the feature/slenderSpeedModifier branch August 13, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: game Everything related to the the game module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant