[IMP] server_environment: module uninstallation - #276
Merged
OCA-git-bot merged 3 commits intoAug 24, 2026
Conversation
ivantodorovich
approved these changes
Jun 30, 2026
ivantodorovich
left a comment
ivantodorovich
left a comment
Contributor
There was a problem hiding this comment.
LG. Pre-commit is failing though :(
yankinmax
force-pushed
the
16.0-server-env-module-uninstall
branch
from
August 19, 2026 14:01
1409635 to
e6e163b
Compare
1 task
Contributor
|
Hello @lmignon can you pls take a look at this PR and possibly trigger merge? |
yankinmax
approved these changes
Aug 19, 2026
lmignon
approved these changes
Aug 19, 2026
Contributor
|
/ocabot merge patch |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
@lmignon The merge process could not be finalized, because command |
This was referenced Aug 19, 2026
Contributor
|
@lmignon what can I do to fix this issue? Do you have any idea? |
Contributor
Generate the files locally to see the result a line 226 and try to resolve the format into the source document to avoid warnings. 🤔 |
Contributor
|
I've added here two backport commits of the: This is needed to be able to add this PR as a dependency to another PR's without conflicts like this one: This conflict is happening, because in v16 we can't have two test dependencies pointing to the same module (from what I see). Once this PR is merged I'll close this one: |
yankinmax
force-pushed
the
16.0-server-env-module-uninstall
branch
from
August 24, 2026 12:54
af4348a to
567c760
Compare
Contributor
simahawk
reviewed
Aug 24, 2026
|
|
||
|
|
||
| @openupgrade.migrate() | ||
| def migrate(env, version): |
Contributor
There was a problem hiding this comment.
do you intend to run this on the next upgrade? The current version is 1.1.1 and this won't have any effect
Contributor
There was a problem hiding this comment.
It's 16.0.1.0.2:
Contributor
There was a problem hiding this comment.
sorry I've probably checked the wrong branch.
BTW next time you can bump the version manually and we can use nobump on merge. This way you have full control.
Contributor
There was a problem hiding this comment.
I was asked several times on different PR's not to bump 😄
yankinmax
force-pushed
the
16.0-server-env-module-uninstall
branch
from
August 24, 2026 13:21
567c760 to
88e0488
Compare
Add a helper to manage the restoring of the database columns when a module using `server_environment` is uninstalled or the dependency on `server_environment` is dropped. Document how to use the helper in an uninstall script or in an upgrade script (if a new version of the addon drops the dependency).
Helper function typically used for hooks and migration scripts. Restores database values for fields transitioning to 'server env managed'. When a field is defined as managed by the server environment, Odoo ignores the value stored in the database, prioritizing the environment configuration instead. If no environment configuration exists, the field may effectively lose its previous value. This method forces to 'persist' these values if they are not explicitly overridden by the current environment configuration.
…cation" To preserve the value of field "smtp_authentication" if we don't set it from the environment. Which may happen to anyone updating the sources of mail_environment for its project.
yankinmax
force-pushed
the
16.0-server-env-module-uninstall
branch
from
August 24, 2026 13:23
88e0488 to
115290d
Compare
Contributor
|
/ocabot merge patch |
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at e2d94da. Thanks a lot for contributing to OCA. ❤️ |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a helper to manage the restoring of the database columns when a module using
server_environmentis uninstalled or the dependency onserver_environmentis dropped.Document how to use the helper in an uninstall script or in an upgrade script (if a new version of the addon drops the dependency).
This is a backward port of #261