[19.0][MIG] contract_sale_picking_tag - #1502
Open
RaphaelVicini wants to merge 4 commits into
Open
Conversation
OCA-git-bot
added
series:19.0
mod:contract_sale_picking_tag
RaphaelVicini
force-pushed
the
19.0-mig-contract_sale_picking_tag
branch
2 times, most recently
from
August 21, 2026 08:18
2f50b81 to
4ba6b16
Compare
| :rtype: _type_ | ||
| """ | ||
| res = super()._get_new_picking_values() | ||
| contract_tags = self.mapped("sale_line_id.order_id.contract_tag_ids") |
Member
There was a problem hiding this comment.
I think in Odoo 19 you can do directly
Can you test?
Suggested change
| contract_tags = self.mapped("sale_line_id.order_id.contract_tag_ids") | |
| contract_tags = self.sale_line_id.order_id.contract_tag_ids |
Contributor
Author
There was a problem hiding this comment.
Thanks for yout review!
FrancoMaxime
left a comment
FrancoMaxime
left a comment
Member
There was a problem hiding this comment.
LGTM: code review
A minor improvment
RaphaelVicini
force-pushed
the
19.0-mig-contract_sale_picking_tag
branch
from
August 24, 2026 08:23
4ba6b16 to
86850b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on (#787)