Skip to content

Updated the paths for the terraform validation action. - #285

Open
kcantrel wants to merge 3 commits into
mainfrom
update_terraform_checks
Open

Updated the paths for the terraform validation action.#285
kcantrel wants to merge 3 commits into
mainfrom
update_terraform_checks

Conversation

@kcantrel

Copy link
Copy Markdown
Collaborator
  • Fixed it where the terraform validation GitHub action is run on all the terraform directories.
  • Fixed a terraform template that was using a deprecated variable.

@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
actions/actions/checkout 8f4b7f84864484a7bf31766abe9204da3cbe65b3 🟢 7
Details
CheckScoreReason
Maintained🟢 1024 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 10
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Code-Review🟢 10all changesets reviewed
Binary-Artifacts🟢 10no binaries found in the repo
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Fuzzing⚠️ 0project is not fuzzed
Packaging⚠️ -1packaging workflow not detected
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Pinned-Dependencies🟢 3dependency not pinned by hash detected -- score normalized to 3
Security-Policy🟢 9security policy file detected
SAST🟢 10SAST tool is run on all commits
Branch-Protection🟢 6branch protection is not maximal on development and all release branches
actions/hashicorp/setup-terraform ed3a0531877aca392eb870f440d9ae7aba83a6bd 🟢 5.9
Details
CheckScoreReason
Maintained🟢 57 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 5
Code-Review🟢 6Found 6/10 approved changesets -- score normalized to 6
Binary-Artifacts🟢 10no binaries found in the repo
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Packaging⚠️ -1packaging workflow not detected
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Pinned-Dependencies🟢 10all dependencies are pinned
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Branch-Protection🟢 6branch protection is not maximal on development and all release branches
Fuzzing⚠️ 0project is not fuzzed
Security-Policy🟢 10security policy file detected
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
actions/step-security/harden-runner fa2e9d605c4eeb9fcad4c99c224cee0c6c7f3594 🟢 7.8
Details
CheckScoreReason
Binary-Artifacts🟢 10no binaries found in the repo
Branch-Protection🟢 8branch protection is not maximal on development and all release branches
CI-Tests🟢 105 out of 5 merged PRs checked by a CI test -- score normalized to 10
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Code-Review🟢 10all changesets reviewed
Contributors🟢 6project has 2 contributing companies or organizations -- score normalized to 6
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Dependency-Update-Tool🟢 10update tool detected
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Maintained🟢 1030 commit(s) and 5 issue activity found in the last 90 days -- score normalized to 10
Packaging⚠️ -1packaging workflow not detected
Pinned-Dependencies🟢 6dependency not pinned by hash detected -- score normalized to 6
SAST🟢 9SAST tool detected but not run on all commits
Security-Policy🟢 10security policy file detected
Signed-Releases⚠️ -1no releases found
Token-Permissions🟢 10GitHub workflow tokens follow principle of least privilege
Vulnerabilities⚠️ 022 existing vulnerabilities detected

Scanned Files

  • .github/workflows/fsxn_rotate_secret_terraform.yml

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Terraform validation workflows to run per-Terraform-directory, and adjusts the FSx ONTAP deployment module to pass region values into the fsxn-rotate-secret Terraform module.

Changes:

  • Updated deploy-fsx-ontap Terraform module to use a different aws_region attribute for fsx_region / secret_region.
  • Added dedicated GitHub Actions workflows to run terraform init + terraform validate for:
    • Management-Utilities/fsxn-rotate-secret/terraform
    • EKS/FSxN-as-PVC-for-EKS/terraform

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
Infrastructure_as_Code/Terraform/deploy-fsx-ontap/module/main.tf Updates region attribute passed to secret-rotation Terraform module inputs.
.github/workflows/fsxn_rotate_secret_terraform.yml Adds Terraform validation workflow scoped to Management-Utilities/fsxn-rotate-secret/terraform.
.github/workflows/fsxn_as_pvc_terraform.yaml Adds Terraform validation workflow scoped to EKS/FSxN-as-PVC-for-EKS/terraform.
Suppressed comments (1)

Infrastructure_as_Code/Terraform/deploy-fsx-ontap/module/main.tf:76

  • Same issue here: data.aws_region.current.region is not a valid attribute for the aws_region data source and will cause Terraform evaluation errors.
module "svm_rotate_secret" {
    source = "github.com/Netapp/FSx-ONTAP-samples-scripts/Management-Utilities/fsxn-rotate-secret/terraform"
    fsx_region = data.aws_region.current.region
    secret_region = var.secrets_region != "" ? var.secrets_region : data.aws_region.current.region

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread Infrastructure_as_Code/Terraform/deploy-fsx-ontap/module/main.tf
Comment thread .github/workflows/fsxn_rotate_secret_terraform.yml Outdated
Comment thread .github/workflows/fsxn_rotate_secret_terraform.yml
Comment thread .github/workflows/fsxn_as_pvc_terraform.yaml Outdated
Comment thread .github/workflows/fsxn_as_pvc_terraform.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants