Updated the paths for the terraform validation action. - #285
Open
kcantrel wants to merge 3 commits into
Open
Conversation
kcantrel
commented
Aug 19, 2026
Collaborator
- Fixed it where the terraform validation GitHub action is run on all the terraform directories.
- Fixed a terraform template that was using a deprecated variable.
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
There was a problem hiding this comment.
Pull request overview
Updates Terraform validation workflows to run per-Terraform-directory, and adjusts the FSx ONTAP deployment module to pass region values into the fsxn-rotate-secret Terraform module.
Changes:
- Updated
deploy-fsx-ontapTerraform module to use a differentaws_regionattribute forfsx_region/secret_region. - Added dedicated GitHub Actions workflows to run
terraform init+terraform validatefor:Management-Utilities/fsxn-rotate-secret/terraformEKS/FSxN-as-PVC-for-EKS/terraform
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| Infrastructure_as_Code/Terraform/deploy-fsx-ontap/module/main.tf | Updates region attribute passed to secret-rotation Terraform module inputs. |
| .github/workflows/fsxn_rotate_secret_terraform.yml | Adds Terraform validation workflow scoped to Management-Utilities/fsxn-rotate-secret/terraform. |
| .github/workflows/fsxn_as_pvc_terraform.yaml | Adds Terraform validation workflow scoped to EKS/FSxN-as-PVC-for-EKS/terraform. |
Suppressed comments (1)
Infrastructure_as_Code/Terraform/deploy-fsx-ontap/module/main.tf:76
- Same issue here:
data.aws_region.current.regionis not a valid attribute for theaws_regiondata source and will cause Terraform evaluation errors.
module "svm_rotate_secret" {
source = "github.com/Netapp/FSx-ONTAP-samples-scripts/Management-Utilities/fsxn-rotate-secret/terraform"
fsx_region = data.aws_region.current.region
secret_region = var.secrets_region != "" ? var.secrets_region : data.aws_region.current.region
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.