Skip to content

Stop libdispatch bulk after value capture failure - #2201

Merged
ericniebler merged 3 commits into
NVIDIA:mainfrom
fallintoplace:fix/libdispatch-bulk-value-capture
Aug 15, 2026
Merged

Stop libdispatch bulk after value capture failure#2201
ericniebler merged 3 commits into
NVIDIA:mainfrom
fallintoplace:fix/libdispatch-bulk-value-capture

Conversation

@fallintoplace

Copy link
Copy Markdown
Contributor

Summary

  • stop libdispatch bulk after predecessor value capture fails
  • add regression coverage for a throwing predecessor value

The receiver already sends set_error when value capture fails. The old code continued into the completion path after that error.

Tests:

  • cmake --build build --target test.exec -j 8
  • ./build/test/exec/test.exec --reporter compact

@copy-pr-bot

copy-pr-bot Bot commented Aug 15, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ericniebler

Copy link
Copy Markdown
Collaborator

/ok to test 3fefbde

@fallintoplace

Copy link
Copy Markdown
Contributor Author

Hey Eric, thanks for approving. I found one more edge case in libdispatch bulk capture for set_value(T&). I’m going to push a small follow-up with the forwarding fix and a regression test. The existing tests pass with it.

@ericniebler

Copy link
Copy Markdown
Collaborator

/ok to test 49b48e9

@ericniebler
ericniebler merged commit 758f41f into NVIDIA:main Aug 15, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants