Skip to content

Fix nvexec split pre-cancellation - #2186

Merged
ericniebler merged 2 commits into
NVIDIA:mainfrom
fallintoplace:fix/nvexec-split-pre-cancellation
Aug 15, 2026
Merged

Fix nvexec split pre-cancellation#2186
ericniebler merged 2 commits into
NVIDIA:mainfrom
fallintoplace:fix/nvexec-split-pre-cancellation

Conversation

@fallintoplace

Copy link
Copy Markdown
Contributor

Summary

  • include set_stopped in the shared completion storage and output signatures
  • initialize shared storage with the stopped completion used by the pre-cancel path
  • add coverage that verifies the predecessor is not started

Testing

  • git diff --check

@copy-pr-bot

copy-pr-bot Bot commented Aug 10, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ericniebler

Copy link
Copy Markdown
Collaborator

/ok to test 7582bad

@ericniebler
ericniebler force-pushed the fix/nvexec-split-pre-cancellation branch from 7582bad to 68afb2e Compare August 14, 2026 23:23
@ericniebler

Copy link
Copy Markdown
Collaborator

/ok to test 68afb2e

@ericniebler
ericniebler merged commit 5625b5e into NVIDIA:main Aug 15, 2026
67 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants