chore(lint): cover valid package.json paths in library-dependencies rule - #236
Draft
cursor[bot] wants to merge 1 commit into
Draft
chore(lint): cover valid package.json paths in library-dependencies rule#236cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Adds filename-aware valid cases so checkPeerDependencies success paths are exercised, raising line coverage from 96.15% to 100% and branch coverage from 87.09% to 100%. No behavior change. Signed-off-by: Cursor Agent <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selected task
coverage for
projects/lint/src/eslint/rules/no-unexpected-library-dependencies.ts.Selector rationale: 1 uncovered lines, 96.15% lines and 87.09% branches, the smallest gap below the 90% threshold.
Before / after
Valid RuleTester cases previously omitted
filename: 'package.json', socheckPeerDependenciesnever returned success. Tests now pass that filename (and one non-package.jsonskip case).Public API
No public API changed. Production rule code is untouched.
Left alone
projects/linthas notest:types,test:axe,test:ssr,test:lighthouse, ortest:visualscripts.