Skip to content

cuda.bindings: Fix API status handling - #2530

Merged
juenglin merged 2 commits into
NVIDIA:mainfrom
juenglin:cufile-check-status-fix
Aug 7, 2026
Merged

cuda.bindings: Fix API status handling#2530
juenglin merged 2 commits into
NVIDIA:mainfrom
juenglin:cufile-check-status-fix

Conversation

@juenglin

@juenglin juenglin commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

closes #2299

Test get_bar_size_in_kb failed on an GH200 system. The clue is in the error shared in #2299:

tests/test_cufile.py::test_get_bar_size_in_kb FAILED

bar_size_kb = cufile.get_bar_size_in_kb(0)

cuda.bindings.cufile.cuFileError:
SUCCESS (0): cufile success; CUDA status: CUDA_ERROR_NOT_SUPPORTED (801)

The cufile status struct has two fields, one for cufile proper, and a second for forwarding potential CUDA driver errors. The CUDA driver error field should be ignored unless the cufile error is CU_FILE_CUDA_DRIVER_ERROR. So the test failed because cuda.bindings incorrectly raised a cuFileError.

The issue fix is here. The PR contains other unrelated changes from re-generating cufile bindings.

@copy-pr-bot

copy-pr-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added CI/CD CI/CD infrastructure cuda.bindings Everything related to the cuda.bindings module labels Aug 7, 2026
@juenglin
juenglin requested review from kkraus14 and mdboom August 7, 2026 17:58
@juenglin
juenglin force-pushed the cufile-check-status-fix branch from 1c3d6f3 to 9ef5766 Compare August 7, 2026 18:06
@juenglin juenglin self-assigned this Aug 7, 2026
@juenglin juenglin added the bug Something isn't working label Aug 7, 2026
@juenglin juenglin added this to the cuda.bindings 13.4.0 & 12.9.8 milestone Aug 7, 2026

@mdboom mdboom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The unrelated changes make sense given the recent generator changes. We should probably do a "catch-up" PR for all of the libraries, but that can be a separate PR.

@juenglin

juenglin commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@copy-pr-bot

copy-pr-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

/ok to test

@juenglin, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@juenglin
juenglin marked this pull request as ready for review August 7, 2026 18:36
@juenglin juenglin added the P0 High priority - Must do! label Aug 7, 2026
@juenglin

juenglin commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 9ef5766

@github-actions

This comment has been minimized.

@juenglin
juenglin merged commit 9ec417f into NVIDIA:main Aug 7, 2026
117 of 119 checks passed
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CI/CD CI/CD infrastructure cuda.bindings Everything related to the cuda.bindings module P0 High priority - Must do!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GH200: test_get_bar_size_in_kb fails with CUDA_ERROR_NOT_SUPPORTED

2 participants