[JAX] Fix counting of synced and wrapped (async, fusion) collectives in HLO - #3412
Open
aybchan wants to merge 2 commits into
Open
[JAX] Fix counting of synced and wrapped (async, fusion) collectives in HLO#3412aybchan wants to merge 2 commits into
aybchan wants to merge 2 commits into
Conversation
aybchan
force-pushed
the
aybchan/fix-collective-count
branch
from
August 21, 2026 17:31
647e981 to
e7af8cb
Compare
Signed-off-by: Alex Y. Chan <alechan@nvidia.com>
aybchan
force-pushed
the
aybchan/fix-collective-count
branch
from
August 21, 2026 17:35
6e11680 to
b76ed95
Compare
for more information, see https://pre-commit.ci
Contributor
Greptile SummaryThe PR updates the JAX distributed-test HLO parser to recognize ROOT-prefixed and synchronous collectives and to resolve collectives hidden behind async or fusion wrappers.
Confidence Score: 5/5The PR appears safe to merge because no concrete changed-code failure remains supported by the available repository evidence. The updated parser preserves direct async classification while adding handling for ROOT syntax, synchronous opcodes, and called computations used by fusion wrappers. Important Files Changed
Reviews (1): Last reviewed commit: "[pre-commit.ci] auto fixes from pre-comm..." | Re-trigger Greptile |
jberchtold-nvidia
self-requested a review
August 21, 2026 17:43
Collaborator
|
/te-ci L1 jax |
Collaborator
|
Change LGTM pending CI. I will merge when CI completes. Thanks Alex! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #3398
With collective fusion, XLA may now emit an all-reduce behind an asynchronous fusion wrapper in HLO:
The parsing logic previously recognized
fusion-startas an async start instruction, but inferred the collective type from its name. Becausefusion-startcontains neitherall-reducenorall-gather, the communication bytes were incorrectly classified asother.Type of change
Changes
Checklist: