Skip to content

docs(readme): add theme-aware banner - #2619

Merged
johnnygreco merged 2 commits into
mainfrom
docs/readme-theme-banner/johnny
Aug 5, 2026
Merged

docs(readme): add theme-aware banner#2619
johnnygreco merged 2 commits into
mainfrom
docs/readme-theme-banner/johnny

Conversation

@johnnygreco

@johnnygreco johnnygreco commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

Replace the README's single SVG banner with theme-aware PNG variants so the OpenShell wordmark remains legible in both GitHub light and dark modes.

Related Issue

No issue required: this is a localized README branding fix.

Changes

Before: current banner in dark mode

Current OpenShell README banner in GitHub dark mode

After

Screenshot 2026-08-05 at 9 57 47 AM Screenshot 2026-08-05 at 9 58 08 AM

Testing

  • mise run pre-commit passes
  • Unit tests added/updated (not applicable; README and image assets only)
  • E2E tests added/updated (not applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

Signed-off-by: Johnny Greco <jogreco@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

All contributors have signed the DCO ✍️ ✅
Posted by the DCO Assistant Lite bot.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

@johnnygreco

Copy link
Copy Markdown
Collaborator Author

I have read the DCO document and I hereby sign the DCO.

Signed-off-by: Johnny Greco <jogreco@nvidia.com>
@johnnygreco

Copy link
Copy Markdown
Collaborator Author

/ok to test e656db1

@johnnygreco
johnnygreco added this pull request to the merge queue Aug 5, 2026
Merged via the queue into main with commit 284da54 Aug 5, 2026
31 checks passed
@johnnygreco
johnnygreco deleted the docs/readme-theme-banner/johnny branch August 5, 2026 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants