docs(readme): add theme-aware banner - #2619
Merged
Merged
Conversation
Signed-off-by: Johnny Greco <jogreco@nvidia.com>
johnnygreco
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
August 5, 2026 13:56
|
All contributors have signed the DCO ✍️ ✅ |
|
🌿 Preview your docs: https://nvidia-preview-pr-2619.docs.buildwithfern.com/openshell |
Collaborator
Author
|
I have read the DCO document and I hereby sign the DCO. |
Signed-off-by: Johnny Greco <jogreco@nvidia.com>
Collaborator
Author
|
/ok to test e656db1 |
pimlock
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the README's single SVG banner with theme-aware PNG variants so the OpenShell wordmark remains legible in both GitHub light and dark modes.
Related Issue
No issue required: this is a localized README branding fix.
Changes
<picture>andprefers-color-schemepattern.Before: current banner in dark mode
After
Testing
mise run pre-commitpassesChecklist