Skip to content

fix(gateway-interceptors): configure connect timeout and HTTP/2 keepalive on interceptor gRPC channel - #2618

Open
letv1nnn wants to merge 1 commit into
NVIDIA:mainfrom
letv1nnn:fix-interceptor-channel-keepalive
Open

fix(gateway-interceptors): configure connect timeout and HTTP/2 keepalive on interceptor gRPC channel#2618
letv1nnn wants to merge 1 commit into
NVIDIA:mainfrom
letv1nnn:fix-interceptor-channel-keepalive

Conversation

@letv1nnn

@letv1nnn letv1nnn commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Summary

The interceptor gRPC channel was dialed bare — Endpoint::from_shared(...).connect() with no connect timeout and no HTTP/2 keepalive. These channels are long-lived: ExecutionPlan::load dials once at startup and the resulting Channel is cloned into every BindingPlan and GatewayInterceptorProfileSource for the process lifetime. With no keepalive, an idle-reaping hop, load-balancer timeout, interceptor redeploy, or GOAWAY silently invalidated the connection, and the failure only surfaced on the next interceptor evaluation. With no connect timeout, an unreachable interceptor host could hang on the OS default TCP connect timeout.

This applies the repo-standard channel tuning (matching openshell-core and openshell-sdk) to both the TCP and unix-socket interceptor channels, so idle connections survive intermediary idle timeouts, dead peers are detected proactively, and dials are bounded.

Related Issue

Closes #2612.

Changes

  • Add tune_endpoint helper in crates/openshell-gateway-interceptors/src/plan.rs applying connect_timeout(10s),
    http2_keep_alive_interval(10s), keep_alive_while_idle(true), keep_alive_timeout(10s), and
    http2_adaptive_window(true).
  • Route connect_endpoint (TCP) and connect_unix_endpoint (unix socket) through tune_endpoint instead of dialing a bare endpoint.

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

@copy-pr-bot

copy-pr-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@pimlock

pimlock commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

/ok to test 81b2589

…live on interceptor gRPC channel

Signed-off-by: Artem Lytvyn <alytvyn@redhat.com>
@letv1nnn
letv1nnn force-pushed the fix-interceptor-channel-keepalive branch from 81b2589 to c2ce5fa Compare August 6, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(gateway-interceptors): configure connect timeout and HTTP/2 keepalive on interceptor gRPC channel

2 participants