refactor(rpm): Moved openshell-gateway.service from RPM to dedicated file - #2592
Open
engelmi wants to merge 1 commit into
Open
refactor(rpm): Moved openshell-gateway.service from RPM to dedicated file#2592engelmi wants to merge 1 commit into
engelmi wants to merge 1 commit into
Conversation
engelmi
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
August 3, 2026 08:52
|
All contributors have signed the DCO ✍️ ✅ |
Author
|
I have read the DCO document and I hereby sign the DCO. |
mrunalp
approved these changes
Aug 3, 2026
engelmi
force-pushed
the
rpm-extract-openshell-gateway
branch
from
August 4, 2026 10:33
1706828 to
e23bbe5
Compare
Author
|
Rebased the branch with the latest changes on main |
…file The inline heredocs in the `openshell.spec` is hard to lint, diff, and edit. Therefore, moving it into a dedicated file so it gets proper syntax highlighting, can be validated by `systemd-analyze verify` and is easier to review in isolation. This also aligns with the .deb packaging. Signed-off-by: Michael Engel <mengel@redhat.com>
engelmi
force-pushed
the
rpm-extract-openshell-gateway
branch
from
August 5, 2026 10:05
e23bbe5 to
a075731
Compare
Author
|
/ok to test |
Author
|
@mrunalp Could you trigger the pending (required) CI runs? It seems I lack the necessary privileges. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The inline heredocs in the
openshell.specis hard to lint, diff, and edit. Therefore, moving it into a dedicated file so it gets proper syntax highlighting, can be validated bysystemd-analyze verifyand is easier to review in isolation.This also aligns with the .deb packaging.
Related Issue
No issue required: Small, mechanical change
Changes
Moves the RPM packaged
openshell-gateway.servicefrom spec file todeploy/rpm/openshell-gateway.serviceTesting
mise run pre-commitpassesUnit tests added/updated(not needed)E2E tests added/updated (if applicable)Checklist
Architecture docs updated (if applicable)