Add configurable web transport paths - #223
Merged
Merged
Conversation
NHAS
reviewed
Jul 25, 2026
| return err | ||
| } | ||
|
|
||
| buildConfig.WSPath, err = line.GetArgString("ws-path") |
Owner
There was a problem hiding this comment.
With both of these as you've got a buffer length of 1024 we need to limit the user here to that length
NHAS
marked this pull request as ready for review
August 4, 2026 22:27
NHAS
added a commit
that referenced
this pull request
Aug 4, 2026
Owner
|
@durck hey can you resubmit this, accidentally merged this to main rather than unstable due to it pointing there |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds configurable web transport paths for WebSocket and HTTP(S) polling transports. Defaults remain
/wsand/push.Details
--ws-pathand--push-pathoptions.--ws-pathand--push-pathoptions.link --ws-pathandlink --push-pathbake paths into generated clients.RSSH_WS_PATHandRSSH_PUSH_PATHinto server startup.Validation
go test ./pkg/transport ./internal/client ./pkg/muxgo test -vet=off ./cmd/client ./cmd/server ./internal/server ./internal/server/commands ./internal/server/webserverbash -n docker-entrypoint.shvia Git Bashgit diff --checkServer package validation uses
-vet=offbecause upstream currently has unrelated non-constant format string vet findings; this PR intentionally does not include formatting-only cleanup.