feat: use QuoteResponse V2 in bridge-controller - #9726
Merged
Conversation
micaelae
changed the base branch from
swaps4546-v2-coercers
to
swaps4546-v2-metadata
July 31, 2026 04:06
Member
Author
|
@metamaskbot publish-preview |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This reverts commit aa5c5d2.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a5a6e0d. Configure here.
4 tasks
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
| // Client can render special UI or skip the quote card row for quotes with missing fee data | ||
| console.error( | ||
| `Failed to compute non-EVM fees for quote ${quote.requestId}:`, | ||
| `Failed to compute non-EVM fees for quote in ${chainId}:`, |
Contributor
There was a problem hiding this comment.
Does this change limit our ability to look these errors up in some way?
Member
Author
There was a problem hiding this comment.
We used to log the requestId, which is not a valid lookup key. But this is a good call, I'll log the quoteId instead since we can actually use it
infiniteflower
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Store and consume QuoteResponse v2 in the bridge-controller. Implements v1<>v2 coercers and metadata merge logic for client and controller compatibility during migration. See changelogs for more details
Draft client PRs
References
Checklist
Note
High Risk
Large breaking API and quote-shape change across swap/bridge/batch-sell paths; incorrect coercion or fee/sorting regressions would affect quote display, fees, and transaction submission.
Overview
BREAKING:
QuoteResponsein@metamask/bridge-controllernow means V2; V1 remains asQuoteResponseV1. Controllerquotesstate, SSE quote streaming, and batch-sell paths coerce incoming payloads withtoQuoteResponseV2and validate against the V2 shape (quote.src/quote.dest, fee arrays, etc.).Quote sorting and batch-sell aggregates move to V2 fields—e.g. default ordering uses
priceData.priceImpactandquote.dest.amount, andselectBatchSellQuotessums destination amounts viasumAmountsinstead of legacy metadata keys.appendFeesToQuotesnow requires a CAIPchainIdand skips fee enrichment when multiple source chains appear in one batch.fetchBatchSellTradesstill posts V1 bodies (toQuoteResponseV1) for backend compatibility while accepting V2 quotes from callers. Metrics helpers read gas/return/symbols from the nested V2 quote structure.@metamask/bridge-status-controller:submitTx,submitIntent, andsubmitBatchSellaccept V2 quotes from clients but normalize to V1 + metadata before existing submission/history logic runs.Reviewed by Cursor Bugbot for commit cf1a542. Bugbot is set up for automated code reviews on this repo. Configure here.