CageuUI ghost cages functionality - #1012
Conversation
aschmidt34
left a comment
aschmidt34
left a comment
There was a problem hiding this comment.
Everything looks good, made a few comments but nothing breaking so this can be merged whenever.
Only thing to triple check is that there will never be a time when the cage number is 0 and NOT a ghost cage. I don't think this is possible, but just wanted to flag it for your consideration.
There was a problem hiding this comment.
Make sure there are no UI (report/query, dropdowns, etc.) using these old lookups.
Seems like you replaced this with the rack_objectid and cage_objectid so this is correct, just wanted to make sure.
| rack_group INTEGER NOT NULL, | ||
| rack_objectid VARCHAR NOT NULL, | ||
| group_rotation INTEGER NOT NULL, | ||
| cage INTEGER NOT NULL, |
There was a problem hiding this comment.
Most places in your CageUI (like cageUi.cage_history) use VARCHAR for 'cage' and INTEGER for 'cage_number'. Not sure if this is a typo or intentional.
| cageObjId: res.rows[0].cage_objectid, | ||
| positionId: res.rows[0].positionid, | ||
| rackGroup: res.rows[0].rack_group, | ||
| rack: 0, |
There was a problem hiding this comment.
Looks odd as the rest are imported from 'res.rows', but I assume this '0' assignment is the entire point of this fetchGhostCage function. If that's the case, this is good to go.
2 participants
Rationale
Added ghost cage functionality for rack assignment to the rooms in the cageUI project.
Related Pull Requests
Changes