Remove SQL Server upgrade scripts and code - #3168
Merged
Merged
Conversation
labkey-jeckels
requested review from
labkey-tchad
and removed request for
a team
August 22, 2026 01:20
labkey-adam
approved these changes
Aug 22, 2026
| dist.versionPrefix = 'Test' | ||
|
|
||
| dist.extraProperties = [supportedDatabases: "pgsql, mssql"] | ||
| dist.extraProperties = [supportedDatabases: "pgsql"] |
Contributor
There was a problem hiding this comment.
Should be able to remove this line. Then we can remove support for the "supportedDatabases" property in the product.
Contributor
Author
There was a problem hiding this comment.
Leaving that for a followup pass once all modules no longer have SupportedDatabases. That prevents needing to merge everything all at once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We no longer support SQLServer as a primary DB
Changes
SupportedDatabasesinmodule.propertiesPostgresOnlyTestNotable deviation: Scripts for creating stored procedures are retained. We want to keep support for them on SQLServer, though we can no longer rely on the module upgrade scripts to install them. We could connect to an external DB that has them for test purposes.