Publish labkey.aws.ssm.enabled for explicit SSM opt-in - #1468
Merged
Conversation
The post-processor already decides whether the operator opted into AWS config, but never told the CloudServices module, which re-derived intent from whatever AWS credentials happened to resolve. Publishing that decision alongside the region and secrets prefix lets SsmSecretProvider gate on it instead. Cloud deployments are unaffected: the flag is published whenever context.awsParameterStore.prefix or context.awsParameterStore.secretsPrefix is configured.
| // SsmClient for on-demand SecretProperty lookups via SecretService at runtime. | ||
| // SsmClient for on-demand SecretProperty lookups via SecretService at runtime. The enabled | ||
| // flag carries the hasExplicitConfig decision above for use in SsmSecretProvider | ||
| System.setProperty("labkey.aws.ssm.enabled", "true"); |
There was a problem hiding this comment.
Minor comment update: This flag is set to True whenever we didn't take the early return above: either explicit config or at least one SSM reference
Contributor
Author
There was a problem hiding this comment.
I revised to reference the class-level docs that already explain in more detail
labkey-gokhano
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
A customer reported ERROR-level SSM logging on an on-premise server that never intended to use AWS SSM, because
SsmSecretProvidertreated any resolvable AWS credentials as a signal to activate. See the linked premiumModules PR for the full symptom.This post-processor already computes the right answer —
hasExplicitConfig— and returns before touching the AWS SDK on-premise. It just never told the module. Publishing that decision lets CloudServices stop inferring intent from whatever credentials happen to resolve.No configuration change is needed in cloud deployments: the flag is published automatically whenever
context.awsParameterStore.prefixorcontext.awsParameterStore.secretsPrefixis set, which cloud already does.Related Pull Requests
Changes
labkey.aws.ssm.enabled=truealongside the region and secrets prefix