Limit the ordinal x-axis padding removal to the calendar axis - #7947
Merged
Conversation
cnathe
approved these changes
Aug 19, 2026
cnathe
left a comment
cnathe
left a comment
Contributor
There was a problem hiding this comment.
Code change matches the removed code from the related PR. I pulled down the change and ran the QCTrendReport.testDataSortOrderInPlot successfully locally.
labkey-jeckels
approved these changes
Aug 20, 2026
labkey-tchad
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Restore the 10-slot minimum x-axis padding for ordinal axes; the calendar work removed it for every TrendingLinePlot caller, but only the calendar axis (which floors its own domain at 10 slots) can't take dateless filler rows.
Related Pull Requests
Changes