Sample color display - grid column renderer, sample detail header, storage box view, etc. - #7932
Merged
Conversation
…E_COLOR_REQUIRED_COLUMNS in requiredColumns
XingY
approved these changes
Aug 17, 2026
cnathe
added a commit
to LabKey/labkey-ui-components
that referenced
this pull request
Aug 18, 2026
…orage box view, etc. (#2056) #### Rationale Surface the sample color assigned via project-level sample colors throughout the sample UI — grid columns, detail views, lineage details, editable grids, and storage capacity breakdowns — and only include the color column where the project actually has active colors defined. Also removes the experimental feature flag now that the feature is complete. #### Related Pull Requests - #2056 - LabKey/labkey-ui-premium#1014 - LabKey/limsModules#2402 - LabKey/platform#7932 - LabKey/testAutomation#3156 #### Changes - Sample listing grids include `ExpMaterialColor` and use `SAMPLE_COLOR_REQUIRED_COLUMNS` for `requiredColumns`; added `QueryInfo.showSampleColorCol` and exported `SAMPLE_COLOR_COLOR_COLUMN_NAME`. - New `App` helpers to read `hasActiveProjectColors` from `moduleContext`, used to gate color display: `getOmittedSampleTypeColumns` adds `SAMPLE_COLOR_REQUIRED_COLUMNS` when no colors are defined in the project, and sample type system fields include `ExpMaterialColor` only when colors are active. - `SampleColorRenderer`: added `cls`, `showLabel`, and `useSmall` props plus styling updates; `SampleColorInput` option renderer now includes `ColorIcon`. - Sample color displayed in lineage details, and included for the aliquot editable field. - `HorizontalBarSection` and `ItemsLegend` handle a section header for the sample type with sample color breakdown. - `QueryModel.flattenValuesFromRow` now carries `displayValue`.
cnathe
added a commit
to LabKey/testAutomation
that referenced
this pull request
Aug 18, 2026
…orage box view, etc. (#3156) ## Rationale See related PR for rationale. This PR adds test helpers for getting various sample color related dom elements. ## Related Pull Requests - LabKey/labkey-ui-components#2056 - LabKey/labkey-ui-premium#1014 - LabKey/limsModules#2402 - LabKey/platform#7932 ## Changes - Selenium test helpers for sample color test cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Server-side foundation for the sample color work: expose the set of active project colors through
ExperimentServiceso clients can determine whether a project has colors defined and gate color display accordingly, and remove the experimental feature flag now that the feature is complete.Related Pull Requests
Changes
ExperimentService.getActiveProjectColors(), which backs thehasActiveProjectColorsmodule context flag consumed by the client apps.ExperimentService.getDataColorLabel()togetDataColor().ExpMaterialColorand useSAMPLE_COLOR_REQUIRED_COLUMNSforrequiredColumns.