Skip to content

Derive observation type from the observation type's category - #748

Open
labkey-martyp wants to merge 1 commit into
release26.7-SNAPSHOTfrom
26.7_fb_derive_observation_type
Open

Derive observation type from the observation type's category#748
labkey-martyp wants to merge 1 commit into
release26.7-SNAPSHOTfrom
26.7_fb_derive_observation_type

Conversation

@labkey-martyp

Copy link
Copy Markdown
Contributor

Rationale

The Observations form let a user pick any observation type but stored every entry as Clinical, so behavior observations recorded there were filed as clinical and dropped out of the behavior views. The form cannot know the right value up front because it depends on which type the user picks for each row, so the type is now derived on save from that type's category. The behavior forms had the same mismatch from the other direction: their Daily Observations shortcut bypassed the type-filtered picker and wrote clinical-category observations and orders labeled as behavior. Rows already saved with a mismatched type need a one-time data fix; this change only affects new entries.

Related Pull Requests

None.

Changes

  • The Observations form no longer defaults an observation's type. The trigger script derives it from the selected observation type's category, while every other form continues to set the type explicitly, including scheduled entries that inherit it from their order.

  • The Daily Observations shortcut is now opt-in per form section rather than always present, so it appears only on the clinical forms.

The Observations form offers every observation type, so it can no longer default the type to Clinical; the trigger script now derives it from the selected type's category, while every other form keeps setting the type explicitly.

The Daily Observations buttons are now opt-in per section, so the behavior forms no longer inject clinical-category observations and orders typed as Behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant