Gradle 9.7.0 and more configuration cache compatibility - #250
Merged
Conversation
…to be compatible with the configuration cache
| task.dbType = properties.shortType | ||
| task.mustRunAfter(BuildUtils.getServerProject(project).tasks.pickMSSQL) | ||
| task.mustRunAfter(BuildUtils.getServerProject(project).tasks.pickPg) | ||
| task.notCompatibleWithConfigurationCache("Walks the project tree") |
Member
There was a problem hiding this comment.
We can safely remove these undeployModulesNotFor* tasks entirely. They only work with non-embedded tomcat and are used to undeploy mssql-only modules, neither of which are relevant anymore.
Contributor
Author
There was a problem hiding this comment.
Awesome. I wondered about that.
Contributor
Author
There was a problem hiding this comment.
It could be that we can remove the UndeployModules task altogether if not used by TeamCity. I'll ask if anyone is actively using it otherwise.
labkey-tchad
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Gradle 9.7.0 is the latest
Several tasks used for building and deploying needed own classes or property adjustments to become compatible with the configuration cache. Use of the configuration cache will be the default with Gradle 10, which is supposedly to be released sometime this year.
There are still some adjustments needed to adhoc tasks related to running tests before we can fully run on TeamCity with the configuration cache enabled. I'll leave this for a later PR.
Related Pull Requests
Changes
verifyLicensePatch,patchApiModule,deployModule,undeployModule,symlinkNode,undeployModulesto configuration-cache compatible tasksModuleFinderto not use deprecatedhasPropertycheck that looks in parent projectModuleDistributionandRunUiTestto be compatible with the configuration cacheMultiGitto mark as not configuration-cache compatibleTeamCityplugin to be compatible with the configuration cacheTestRunner'scompileUITestJavatask to be config-cache compatible and move the declaration of theaspectjconfiguration to that plugin