check if the link exists in readthedocs. Fixes #447 - #1080
Merged
Conversation
merge dev upstream 19082026
…h flag. But now it is more robust. Fixes KnowledgeCaptureAndDiscovery#510. Note: Mock tests were written with AI helped. Some mockups are still too complex for me to build on my own.
dgarijo
reviewed
Aug 24, 2026
| repo_type = constants.RepositoryType.GITHUB | ||
| repository_metadata = Result() | ||
| def_branch = "main" | ||
| def_branch = "master" |
Collaborator
There was a problem hiding this comment.
thee default branch is not master. It is main. This is incorrect.
dgarijo
requested changes
Aug 24, 2026
dgarijo
left a comment
dgarijo
left a comment
Collaborator
There was a problem hiding this comment.
Please see the comments
Contributor
Author
|
so... the defautl branch should be 'main'? I changed that because in some places we had main and in other master. I tried to unify the code. |
Collaborator
|
Right now the default branch is always main in new repos. So the default should be main, the fallback is master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.