Add Legend watch face

[DavisNT]

An elegant and very practical digital watch face.

Uses only fonts already in InfiniTime and no external resources. Has the standard functionality:

• shows time, date (without year) and day of week
• supports 24 and 12 hour time formats
• BLE, new notification and alarm clock icons
• battery percentage (green when charging)
• steps and heart rate
• temperature and weather icon

Additionally:

• visual indication (amber dot) for any notification(s)
• visual indication (red or blue line) when notifications are muted
• battery percentage turns red when 20% or less
• stopwatch and timer icons (when active)
• colorful sun, snow and thunderstorm weather icons
• generally uses brighter colors for more urgent things

[github-actions]

Build size and comparison to main:

Section	Size	Difference
text	388368B	3136B
data	944B	0B
bss	22640B	0B

Run in InfiniEmu

[mark9064]

Looks great overall :)

A few comments, but nothing big

I am curioous, how much did you use LLMs (if at all) during development of this watchface?

[DavisNT]

@mark9064 Thanks for the fast review!
Initial version of the design and initial code was generated by LLM (Claude Fable 5), afterwards things were fixed and more functionality (weather icon, service icons am/pm indicator etc.) was added.

I have fixed the issues you highlighted and rebased the PR. Can you please review again?

[mark9064]

I think the code itself is all good. Could you take a look at all the comments though, some of them seem a bit overblown - I would say that most of the description isn't needed because if I want detail I will read the code. Visual markers for sections are probably still useful though. I've highlighted a few here

I find LLMs quite like to do this with comments :)

Also, have you tested this with AOD? Does it still look OK? (It's fine if some UI elements disappear that aren't important, but it needs to stay usable)

[DavisNT]

@mark9064 Thanks!
I have removed or changed the comments.
Also the shortening of steps has been removed (as it didn't actually shorten the label).
The watch face is tested with Always On Display - and only the bottom row labels (stepCaption, heartbeatCaption and weatherCaption) become invisible. I think it looks good with AOD.

[DavisNT]

@mark9064 If any other adjustments are needed, please let me know!
Also, here are screenshots after removal of the "shortening" of steps count.

[mark9064]

I think there are still a couple verbose comments, I don't think any of them need to be longer than a line. The rewords you have done so far are nice improvements :)

Looks great!

[DavisNT]

@mark9064 Thanks for the feedback!
Just shortened 2 last multiline comments.

Can you please review?

[mark9064]

LGTM :)

[DavisNT]

@mark9064 Could it be possible to put this already in 1.17.0?
And is there anything I can do to help this PR to get merged?

P.S. The force-push a couple minutes ago was just rebase using GitHub web (no code changes there).

[mark9064]

Nothing to do on your end, just waiting for a second review

[SteveAmor]

Hi @DavisNT thanks for this watch face, I really like it. I've tested on the simulator and am running this watch face as my daily driver now and that's working well too.

Would you be able to move the Refresh() in the WatchFaceLegend.cpp before the taskRefresh. It's something that is slowly being implemented across screens.

It would be good if @mark9064 could chime in on this suggestion. The Services (Alarm, Timer, StopWatch) here https://github.com/DavisNT/InfiniTime/blob/3caae05b9b5f6130c36bbdc2d79c04abc75fc9d8/src/displayapp/screens/WatchFaceLegend.cpp#L168 will never update after the watch face is created so they don't really need to be dirty values and can be "drawn" on entry here https://github.com/DavisNT/InfiniTime/blob/3caae05b9b5f6130c36bbdc2d79c04abc75fc9d8/src/displayapp/screens/WatchFaceLegend.cpp#L57. When they do change, you have moved away from the watch face.

[mark9064]

Good spot - yes, the refresh call should move before

Your dirtyvalue analysis is correct. I think it's nice to be defensive though when it's almost free. If we wanted to allow changing them say with the companion app in the future, there is now less to change

PS you can use the review tool on the files page when you have comments like this and leave them in specific locations so people can see what you're talking about easily

[DavisNT]

@SteveAmor Thank you very much for the review and analysis!

I have moved the Refresh() call before assigning the taskRefresh.
As @mark9064 suggested, I have left the DirtyValue-s for the Services (Alarm, Timer, StopWatch).

P.S. Sorry for the repeated pushes! I accidentally pushed old version first.