Skip to content

feat: add fill toggle and opacity slider for bulk annotations - #426

Open
igoroctaviano wants to merge 1 commit into
masterfrom
feature/bulk-annotation-fill
Open

feat: add fill toggle and opacity slider for bulk annotations#426
igoroctaviano wants to merge 1 commit into
masterfrom
feature/bulk-annotation-fill

Conversation

@igoroctaviano

Copy link
Copy Markdown
Collaborator

Summary

  • Add UI controls in the annotation group display settings for enabling fill on polygon annotations
  • Toggle switch to enable/disable fill
  • Opacity slider (0-1) that is disabled when fill is off
  • Fill settings only shown for POLYGON, RECTANGLE, and ELLIPSE graphic types

Changes

  • AnnotationGroupItem.tsx: Added fill toggle, fill opacity slider, and handlers
  • AnnotationGroupList.tsx: Updated interface to include fill style options
  • SlideViewer.tsx: Updated style change handler to pass fill options to DMV

Dependencies

Test plan

  • Load a slide with bulk polygon annotations
  • Open display settings for an annotation group with POLYGON graphic type
  • Verify the Fill section appears with toggle and opacity controls
  • Enable fill and verify polygons render with fill color
  • Adjust fill opacity and verify the opacity changes
  • Verify the fill opacity slider/input is disabled when fill is off
  • Verify POINT and POLYLINE annotation groups do not show fill settings

🤖 Generated with Claude Code

Add UI controls in the annotation group display settings for enabling
fill on polygon annotations:
- Toggle switch to enable/disable fill
- Opacity slider (0-1) that is disabled when fill is off
- Only shown for POLYGON, RECTANGLE, and ELLIPSE graphic types

The fill settings are passed to dicom-microscopy-viewer's
setAnnotationGroupStyle() method.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@sonarqubecloud

Copy link
Copy Markdown

@deepsource-io

deepsource-io Bot commented Aug 14, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in f726405...702634d on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript Aug 14, 2026 9:18p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@github-actions

Copy link
Copy Markdown

🔗 Firebase Preview - Linked to DMV Branch

This preview is using a linked dicom-microscopy-viewer branch:

Branch feature/bulk-annotation-fill
Commit d08d452
Source matching-branch

To change the DMV branch, edit dmv-branch: <branch-name> in the PR description.

@github-actions

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 702634d):

https://idc-external-006--pr426-feature-bulk-annotat-jqrw0bbw.web.app

(expires Fri, 21 Aug 2026 21:22:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 88aacecd98ba54d2f9c8d201a9444e43d1ad8307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant