Skip to content

fix(ci): run DMV build in node_modules directory - #425

Merged
igoroctaviano merged 1 commit into
masterfrom
fix/dmv-build-in-node-modules
Aug 14, 2026
Merged

fix(ci): run DMV build in node_modules directory#425
igoroctaviano merged 1 commit into
masterfrom
fix/dmv-build-in-node-modules

Conversation

@igoroctaviano

Copy link
Copy Markdown
Collaborator

Summary

Fixes the DMV build command in the Firebase deploy workflow. pnpm --filter only works for workspace projects, not dependencies in node_modules.

Problem

The previous command pnpm --filter dicom-microscopy-viewer run build fails with:

No projects matched the filters in "/home/runner/work/slim/slim"

Solution

Run the build directly in the node_modules directory:

(cd node_modules/dicom-microscopy-viewer && pnpm run build)

Test plan

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com

pnpm --filter only works for workspace projects, not dependencies.
Run the build directly in node_modules/dicom-microscopy-viewer instead.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@sonarqubecloud

Copy link
Copy Markdown

@deepsource-io

deepsource-io Bot commented Aug 14, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in c580627...ceaeb79 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript Aug 14, 2026 12:54p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@github-actions

Copy link
Copy Markdown

📦 Firebase Preview - Using Published DMV

This preview is using the published dicom-microscopy-viewer from package.json:

Version ^0.48.23

To link a DMV branch for testing (requires an open PR in DMV):

  • Add dmv-branch: <branch-name> to the PR description, OR
  • Use the same branch name in both repos (automatic matching)

@github-actions

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit ceaeb79):

https://idc-external-006--pr425-fix-dmv-build-in-nod-4li909ro.web.app

(expires Fri, 21 Aug 2026 12:56:27 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 88aacecd98ba54d2f9c8d201a9444e43d1ad8307

@igoroctaviano
igoroctaviano merged commit 72a8377 into master Aug 14, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant