ci: dynamically allow DMV git tarball builds - #424
Conversation
pnpm 11's dependency status check fails when the git-hosted dicom-microscopy-viewer's tarball URL isn't in allowBuilds. Instead of hardcoding a SHA that goes stale, dynamically insert the resolved DMV_SHA into pnpm-workspace.yaml before install. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript | Aug 14, 2026 12:38p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
📦 Firebase Preview - Using Published DMVThis preview is using the published
|
|
Visit the preview URL for this PR (updated for commit c9395bd): https://idc-external-006--pr424-fix-dynamic-dmv-allo-maaxmd8h.web.app (expires Fri, 21 Aug 2026 12:41:04 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 88aacecd98ba54d2f9c8d201a9444e43d1ad8307 |



Summary
pnpm-workspace.yaml'sallowBuildsduring CIdicom-microscopy-viewerProblem
pnpm 11 introduced a security feature that blocks build scripts from dependencies by default. When the Firebase preview workflow resolves a DMV branch to a specific commit SHA, pnpm stores it as
dicom-microscopy-viewer@https://codeload.github.com/.../tar.gz/<SHA>. The staticallowBuilds: dicom-microscopy-viewer: trueentry only matches npm-published versions, not git tarballs.Previously, this required hardcoding the SHA in
pnpm-workspace.yaml, which went stale whenever the DMV branch got new commits.Solution
The workflow now dynamically inserts the resolved tarball URL into
allowBuildsbefore runningpnpm install, so any DMV commit SHA is automatically approved.Test plan
🤖 Generated with Claude Code