Skip to content

fix(i18n): handle missing date formats #17501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
viktorkombov wants to merge 4 commits into
base: master
Choose a base branch
from
+11 −5
Open

fix(i18n): handle missing date formats #17501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e2c51e8
fix(i18n): handle missing date formats
viktorkombov Aug 11, 2026
d926602
fix(formatter): allow null or undefined format in formatDate method
viktorkombov Aug 12, 2026
0b20b5e
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular…
viktorkombov Aug 14, 2026
e128e00
Merge branch 'master' into vkombov/bug-17493
viktorkombov Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions projects/igniteui-angular/core/src/core/i18n/formatters/formatter-base.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,14 @@ describe('Localization', () => {
expect(i18nFormatter.formatDate('2025-01-25T14:15:00', 'ex: HH:mm GGG', 'en-US')).toEqual('ex: 14:15 AD');
});

it('should return an empty string when the format is missing', () => {
const value = '2025-01-25T14:15:00';

expect(i18nFormatter.formatDate(value, undefined, 'en-US')).toEqual('');
expect(i18nFormatter.formatDate(value, null, 'en-US')).toEqual('');
expect(i18nFormatter.formatDate(value, '', 'en-US')).toEqual('');
});

it('should return correct date format per locale', () => {
// Defaults to Angular's one because they are registered in tests
expect(i18nFormatter.getLocaleDateTimeFormat('en', false)).toEqual('M/d/yyyy');
Expand Down
6 changes: 2 additions & 4 deletions projects/igniteui-angular/core/src/core/i18n/formatters/formatter-base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,8 @@ export class BaseFormatter {
/**
* Format provided date to reflect locales format. Similar to Angular's formatDate.
*/
public formatDate(value: Date | string | number | null | undefined, format: string, locale: string, timezone?: string): string {
// Mirror Angular's DatePipe, which defaults to 'mediumDate' when no format is supplied.
// A null/empty format would otherwise reach ngFormatDate and throw on `format.length`.
return value != null ? ngFormatDate(value, format || 'mediumDate', locale, timezone) : '';
public formatDate(value: Date | string | number | null | undefined, format: string | null | undefined, locale: string, timezone?: string): string {
return value != null && format ? ngFormatDate(value, format, locale, timezone) : '';
Comment thread
viktorkombov marked this conversation as resolved.
}

/** Format number value based on locale */
Expand Down
2 changes: 1 addition & 1 deletion projects/igniteui-angular/core/src/core/i18n/formatters/formatter-intl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export class IntlFormatter extends BaseFormatter {
}
}

public override formatDate(value: Date | string | number | null | undefined, format: string, locale: string, timezone?: string): string {
public override formatDate(value: Date | string | number | null | undefined, format: string | null | undefined, locale: string, timezone?: string): string {
if (value === null || value === undefined || value === '') {
return '';
}
Expand Down
Loading