Update edgezero to chunked-config GC rev and wire ts config gc - #1020
Closed
aram356 wants to merge 5 commits into
Closed
Update edgezero to chunked-config GC rev and wire ts config gc#1020aram356 wants to merge 5 commits into
aram356 wants to merge 5 commits into
Conversation
Move the edgezero dependency pins from tag v0.0.4 to the head of stackpop/edgezero#314, which adds best-effort chunk garbage collection for Fastly config-store pushes and a new untyped `config gc` subcommand. - Wire `ts config gc` (ConfigGcArgs / run_config_gc) following the updated upstream CLI template; gc inspects the store's physical entries, so it is not parameterised over TrustedServerAppConfig - Adapt TrustedServerAppConfig to the AppConfigMeta trait change (SECRET_FIELDS const replaced by a secret_fields() method) - Ignore the new `.*.edgezero-lock` local config-push lock sidecar
Point the edgezero dependency pins at the spec/fastly-chunk-gc branch (stackpop/edgezero#314) so `cargo update` follows the PR as it evolves; the lockfile currently resolves it to 0873ec5a.
aram356
marked this pull request as draft
August 13, 2026 16:26
stackpop/edgezero#314 landed on main (merge 3d3ddf3c), so move the dependency pins from the spec/fastly-chunk-gc branch to main; the lockfile resolves it to 40377bae. No new release tag exists yet.
Collaborator
Author
|
Closing in place of #940 which includes it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adopts the new commands from stackpop/edgezero#314 (Fastly chunked-config GC, merged 2026-08-14): the edgezero dependency pins move from tag
v0.0.4tobranch = "main", and thetsCLI gains the newconfig gcsubcommand.Changes
Cargo.toml,Cargo.locktag = "v0.0.4"→branch = "main"crates/trusted-server-cli/src/run.rsts config gc(ConfigGcArgs→edgezero_cli::run_config_gc) following the updated upstream CLI template, plus parse testscrates/trusted-server-core/src/config.rsAppConfigMetatrait change:SECRET_FIELDSconst replaced by asecret_fields()method (still empty for Trusted Server).gitignore.*.edgezero-lock, the new local config-push advisory-lock sidecar written next tofastly.tomlconfig gcis untyped (it inspects the store's physical entries, not the typed app config), dry-run by default, and deletes only with--yesplus an explicit--older-thanwindow.config pushnow also garbage-collects the superseded chunk generation on re-push (cloud and--local), so re-pushing a changedtrusted-server.tomlno longer leaks the prior generation of chunk entries.Test plan
All run against edgezero main
40377bae:./scripts/test-cli.sh— all pass, including newconfig gcparse teststs config gc --helpsmoke test (parses and renders upstream arg docs)cargo check-fastly/check-axum/check-cloudflare/check-spincargo test-fastly(2000+ tests) /test-axum/test-cloudflare/test-spincargo clippy-fastly/-axum/-cloudflare/-cloudflare-wasm/-spin-native/-spin-wasm— cleancargo fmt --all -- --check— clean