Feat/viewer app controller - #170
Open
JulienChampagnol wants to merge 15 commits into
Open
Conversation
…-solutions/OpenGeodeWeb-Viewer into feat/viewer_app_controller
…-solutions/OpenGeodeWeb-Viewer into feat/viewer_app_controller
BotellaA
reviewed
Aug 10, 2026
| ) | ||
| params = schemas.Visibility.from_dict(rpc_params) | ||
| self.SetPointsVisibility(params.id, params.visibility) | ||
| return params.to_dict() |
Member
There was a problem hiding this comment.
Un peut chiant ça non ? On peut pas ajouter plutôt le to_dict dans le décorateur. Ça serait cool de n'avoir aucun changement à faire (sauf le typage)
Member
There was a problem hiding this comment.
On pourrait renvoyer le type schema.Visibility? Ça serait sympa pour la clarté du code non ?
BotellaA
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.