Fix #892: ignore whitespace-only unnamed XML text as unknown property - #898
Open
arimu1 wants to merge 1 commit into
Open
Fix #892: ignore whitespace-only unnamed XML text as unknown property#898arimu1 wants to merge 1 commit into
arimu1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #892
Root cause
Pretty-printed XML with attribute-only beans/records exposes whitespace-only element body as the unnamed XML text property (
""by default). WithFAIL_ON_UNKNOWN_PROPERTIESthat synthetic property is treated as unknown, even though it is only formatting whitespace between the start and end tags.This is the same unnamed-text channel used for
@JacksonXmlText([dataformat-xml#565]); it should fail only when the text is actual unknown content.Change
XmlDeserializationContext.handleUnknownPropertyto skip the unnamed text property when its value is whitespace-only.@JacksonXmlTextis unchanged (the property is known).Test plan
WhitespaceOnlyUnknownProp892Test— issue XML on records + POJO; non-whitespace body stillUnrecognizedPropertyExceptionXmlTextWhitespace565Test,EmptyBeanDeser318Test,XmlEmptyRecordDeser508Test,XmlRecordDeser735Test,XmlClassDeser735Test,TextValueTest,XmlTextTestmvn teston JDK 21AI-assisted (Composer 2.5); human-reviewed.