read stream to end for negative length in writeBinary(InputStream) - #894
Open
Sahana2524 wants to merge 1 commit into
Open
read stream to end for negative length in writeBinary(InputStream)#894Sahana2524 wants to merge 1 commit into
Sahana2524 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raw exception from writeBinary when stream length is unknown
writeBinary(Base64Variant, InputStream, int)treats a negativedataLengthas a real length, but per theJsonGeneratorcontract a negative value means "length unknown, read to the end of stream", and the JSON backend already handles it that way. The attribute path reachesnew byte[dataLength]and the element path a boundedread(..., dataLength), so the call leaves the generator as a rawNegativeArraySizeException/IndexOutOfBoundsExceptioninstead of aJacksonException. Reading the stream to the end and then reusing the existingbyte[]path (which Stax2 needs for the full-buffer/attribute writes anyway) keeps the output identical to the JSON backend for the same input; non-negative lengths are untouched.