Skip to content

Fix Global Reimbursement incorrectly appearing disabled for fully set-up US Corpay accounts - #98347

Draft
MelvinBot wants to merge 1 commit into
mainfrom
claude-globalReimbursementCorpayGate
Draft

Fix Global Reimbursement incorrectly appearing disabled for fully set-up US Corpay accounts#98347
MelvinBot wants to merge 1 commit into
mainfrom
claude-globalReimbursementCorpayGate

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

The "Enable global reimbursements" button on the Wallet bank-account detail view was gated on the absence of additionalData.corpay.achAuthorizationForm. That field is only written when a US business account is enabled through the NewDot Corpay onboarding flow, so accounts that were fully enabled for Global Reimbursement outside that flow (e.g. in Expensify Classic) never had it — causing NewDot to show the "enable" button for accounts that are already enabled.

This swaps the gate to key off the account's actual Corpay verification status, additionalData.verifications.corpay, which the backend now returns for every enabled account regardless of the surface that enabled it (the backend work landed on prod — see the issue thread). verifications.corpay is absent for non-Corpay accounts, so the negated check !...verifications?.corpay correctly shows the button only when the account is not yet enabled.

Changes:

  • src/types/onyx/BankAccount.ts — added the verifications.corpay field to BankAccountAdditionalData so the front end can read the real status.
  • src/pages/settings/Wallet/WalletPage/index.tsx — updated shouldShowEnableGlobalReimbursementsButton to gate on !additionalData?.verifications?.corpay instead of !additionalData?.corpay?.achAuthorizationForm. The USD / business-type / open-state guards are unchanged.
AI tests run locally by MelvinBot
  • npm run fmt (oxfmt) — no changes to the two files
  • npm run typecheck-tsgo — passed
  • npm run lint-changed — passed
  • npm run react-compiler-compliance-check check src/pages/settings/Wallet/WalletPage/index.tsx — passed
  • npm test tests/unit/WalletPageUtilsTest.ts — 3 passed

Fixed Issues

$ #96385
PROPOSAL: #96385 (comment)

Tests

// TODO: The human co-author must fill out the manual tests before marking this PR as "ready for review". Suggested flow:
// 1. Sign in with an account that has a US business bank account enabled for Global Reimbursement outside the NewDot flow (e.g. enabled in Classic).
// 2. Go to Account > Wallet and open that bank account.
// 3. Verify the "Enable global reimbursements" button is NOT shown (account is already enabled).
// 4. Repeat with a US business account that is NOT enabled for Global Reimbursement and verify the button IS shown.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Co-authored-by: Maxence Coulibaly <madmax330@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I looked at the failing checks — both are process/human checks, not code failures, so there's nothing for me to fix in code:

  • PR Author Checklist / checklist — failing because 0 of 38 checklist boxes are ticked. This requires the human co-author to fill out the Tests and QA Steps sections (they currently have // TODO placeholders) and check the boxes.
  • Check independent approval — failing because the PR hasn't yet received an independent reviewer's approval.

Every actual code check is green: typecheck, ESLint, all 8 test jobs, Bun tests, Compare knip issues, Storybook tests, Oxfmt, React Compiler Compliance, spellcheck, and the perf tests.

Next step: the human co-author needs to complete the author checklist (fill in Tests/QA and tick the boxes), then get a reviewer approval — I can't do either of those on your behalf.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

⚠️ Something went wrong. This may be a transient issue — try again. If it persists, check status.anthropic.com.

Run details

@huult

huult commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot Could you please assign this PR to me?

@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 Done — you've been added as an assignee on this PR, huult.

@huult

huult commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot Check all items on the author checklist, I will verify them later.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 Done — I've checked off every item in the PR Author Checklist, huult.

A couple of things I left untouched for you to fill in before marking this ready for review:

  • The Tests and QA Steps sections still have // TODO placeholders — those need real steps.
  • The Screenshots/Videos sections are empty.

I only ticked the checklist boxes as you asked; please verify each item actually holds before this goes up for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants