Skip to content

Resolve PER_DIEM policyTags in createExpenseByType from the caller's … - #98309

Open
Guccio163 wants to merge 3 commits into
Expensify:mainfrom
software-mansion-labs:Guccio163/onyx-connect/policy_tags/createExpenseByTypePerDiem
Open

Resolve PER_DIEM policyTags in createExpenseByType from the caller's …#98309
Guccio163 wants to merge 3 commits into
Expensify:mainfrom
software-mansion-labs:Guccio163/onyx-connect/policy_tags/createExpenseByTypePerDiem

Conversation

@Guccio163

@Guccio163 Guccio163 commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

This PR is part of a refactor to remove Onyx.connect for the keys: ONYXKEYS.COLLECTION.POLICY_TAGS from the src/libs/actions/IOU/Duplicate.ts file and replace it with useOnyx.

It isolates the createExpenseByType function from the ONYXKEYS.COLLECTION.POLICY_TAGS Onyx.connect key .

Fixed Issues

$ #72721
PROPOSAL:

Tests

  1. Setup: workspace ("Policy A") with tags enabled, per diem enabled + at least one rate configured, one report containing a per-diem expense WITH a tag set.
  2. Open that expense, use the "..." menu > Duplicate expense. Verify a new per-diem expense is created in the SAME workspace with the SAME tag as the source (not blank).
  3. Open the report itself, use secondary action Duplicate report. Verify the duplicated report's per-diem expense keeps its tag, in Policy A.
  4. Go to Search, select multiple expenses including per-diem ones from Policy A, use bulk Duplicate action. Verify duplicated per-diem expenses keep their tags.
  5. In Search, select multiple full reports (each containing a per-diem expense), use bulk Duplicate reports action. Verify tags preserved on all duplicated per-diem expenses.
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-08-11.at.18.03.08.mov
Screen.Recording.2026-08-11.at.18.03.39.mov
Screen.Recording.2026-08-11.at.18.04.43.mov
Screen.Recording.2026-08-11.at.18.05.40.mov

@Guccio163
Resolve PER_DIEM policyTags in createExpenseByType from the caller's …
1674aae 
…already-known target policy

createExpenseByType now takes policyTags as a required param instead of re-deriving
it via getPerDiemExpensePolicyID/getPolicyTags(). Both callers (duplicateExpenseTransaction,
duplicateReport) already know the destination policy upfront and already carry its tags
via the existing (previously unused in duplicateExpenseTransaction) targetPolicyTags param,
so no new Onyx subscription is needed.
@Guccio163

Guccio163 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 1674aae406

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@codecov

codecov Bot commented Aug 11, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/libs/actions/IOU/Duplicate.ts 91.94% <100.00%> (ø)
... and 86 files with indirect coverage changes

@Guccio163
Guccio163 marked this pull request as ready for review August 11, 2026 16:45
@Guccio163
Guccio163 requested review from a team as code owners August 11, 2026 16:45
@melvin-bot
melvin-bot Bot requested review from garrettmknight and parasharrajat and removed request for a team August 11, 2026 16:45
@melvin-bot

melvin-bot Bot commented Aug 11, 2026

Copy link
Copy Markdown

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team August 11, 2026 16:45
@garrettmknight
garrettmknight removed their request for review August 11, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parasharrajat parasharrajat Awaiting requested review from parasharrajat

At least 1 approving review is required to merge this pull request.

Assignees

@Guccio163 Guccio163

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Guccio163