Skip to content

Fixed multiple enchantings on items #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Postremus wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed multiple enchantings on items #108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/sk89q/commandbook/kits/FlatFileKitsManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ public synchronized void load() {
continue;
}

String[] parts = line.split(",");
String[] parts = line.split("#");
ItemStack item = ItemUtil.getItem(parts[0].replace(" ", ""));

@DarkArc DarkArc Nov 30, 2014

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the best character to use at the very least. # is a comment character if I recall correctly. Also, this breaks backwards compatibility with various kits, does it not?

I'm pretty sure just from looking at the code here, kits follow their own syntax, so I think the real issues is enchants were never properly implemented for kits.

EDIT: I take that back, it's setting item quantity, and that seems to be all.


if (item == null) {
Expand Down