ドキュメントと実装の乖離を修正（旧プラグイン名・構造図・日本語ローカライズ・.uplugin） - #80
Merged
EmbarrassingMoment merged 2 commits intoAug 22, 2026
Merged
Conversation
…tion Documentation: - README / QUICKSTART (en/ja): installation steps and project structure referenced the pre-rename plugin directory (Plugins/MarkdownEditor, MarkdownEditor.uplugin); corrected to Plugins/MarkdownAsset and the actual Source/ThirdParty/md4c layout. - README.ja: fixed wording (ニバイト文字 -> マルチバイト文字) and the Planned Features heading (必須ランタイム -> ランタイム). - MarkdownAsset.uplugin: description updated to cover the outline panel, wikilinks / asset & class links, and Markitdown conversion. Localization: - Added the 25 missing entries (all Markitdown UI strings from 1.3.0 and the new Outline panel strings) to the MarkdownEditor localization manifest and en/ja archives, with Japanese translations, and regenerated the compiled en/ja .locres files. Source strings were extracted from the .cpp files to keep source hashes exact, and the generation pipeline was validated by reproducing the existing manifest/archive/locres files byte-for-byte first. - Declared the MarkdownEditor localization target in MarkdownAsset.uplugin (LocalizationTargets, LoadingPolicy=Editor) so the bundled translations load for standalone plugin installs; the plugin now ships only the compiled .locres/.locmeta data while authoring data stays in the project's Content/Localization. - Removed the stale pre-rename Plugins/MarkdownEditor/ localization leftovers. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G398YQHzHYChvMpRonbFTM
Newer MSVC toolchains (UE 5.8+) report unreachable code (C4702) inside the third-party md4c.c and promote it to an error. Since md4c sources must not be modified, disable the warning in the md4c_all.c unity build wrapper for MSVC only. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
ブランチレビューで検出した「🟠 ドキュメントと実装の乖離」6項目を修正します。
変更内容
1. 旧プラグイン名の残存を修正
Plugins/MarkdownEditor→Plugins/MarkdownAssetに修正MarkdownAsset.uplugin、md4c の実際の位置Source/ThirdParty/md4c/、エディタモジュールの内容にアウトライン・markitdown 連携・テストを追記）2. 日本語ローカライズの欠落を解消（25キー）
Content/Localization/MarkdownEditorの manifest / en・ja archive を更新し、コンパイル済み.locresを再生成.cppから直接抽出して照合し、フォーマット引数{0}等の欠落もチェック済み3. プラグイン単体配布時のローカライズ読み込みを修正
MarkdownAsset.upluginにLocalizationTargets（MarkdownEditor,LoadingPolicy: Editor）を宣言。これまでプラグイン同梱の翻訳データは単体インストールでは読み込まれていませんでしたContent/Localizationはランタイムに必要な.locres/.locmetaのみに整理（manifest / archive / po / csv は Localization Dashboard が使うプロジェクト側Content/Localizationに一本化し、二重管理によるドリフトを防止）4. リネーム残骸の削除
Plugins/MarkdownEditor/（.uplugin を持たないローカライズ残骸ディレクトリ、10 ファイル）を削除5. README.ja の表記修正
6. .uplugin の Description 更新
CHANGELOG
### Fixedとして上記を記載補足
.po（エクスポート成果物）は今回更新していません。次回 Localization Dashboard でのエクスポート時に再生成されます🤖 Generated with Claude Code
https://claude.ai/code/session_01G398YQHzHYChvMpRonbFTM
Generated by Claude Code