build: set PYTHON in nix flake so that the docs build - #9245
Open
notjustanyusername wants to merge 1 commit into
Open
build: set PYTHON in nix flake so that the docs build#9245notjustanyusername wants to merge 1 commit into
notjustanyusername wants to merge 1 commit into
Conversation
Andezion
reviewed
Jul 23, 2026
Andezion
left a comment
Collaborator
There was a problem hiding this comment.
Do you have an actual build log or reproduction showing the docs/msggen/grpc-proto step failing on current master without this change? Since the flake check isn't in CI anymore, that's currently unverifiable from CI history - it'd help to see the concrete failure this is meant to resolve, or confirm whether this is speculative hardening rather than an observed fix
Collaborator
|
I think this fix is more appropriate #9423. What do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I notice the nix flake check was removed in #8743. Without the check in CI the flake will keep breaking.
tools/lightning-downgrade