Skip to content

build: set PYTHON in nix flake so that the docs build - #9245

Open
notjustanyusername wants to merge 1 commit into
ElementsProject:masterfrom
notjustanyusername:master
Open

build: set PYTHON in nix flake so that the docs build#9245
notjustanyusername wants to merge 1 commit into
ElementsProject:masterfrom
notjustanyusername:master

Conversation

@notjustanyusername

Copy link
Copy Markdown

I notice the nix flake check was removed in #8743. Without the check in CI the flake will keep breaking.

  • The changelog has been updated in the relevant commit(s) according to the guidelines.
  • Tests have been added or modified to reflect the changes.
  • Documentation has been reviewed and updated as needed.
  • Related issues have been listed and linked, including any that this PR closes.
  • Important All PRs must consider how to reverse any persistent changes for tools/lightning-downgrade

@Andezion Andezion left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have an actual build log or reproduction showing the docs/msggen/grpc-proto step failing on current master without this change? Since the flake check isn't in CI anymore, that's currently unverifiable from CI history - it'd help to see the concrete failure this is meant to resolve, or confirm whether this is speculative hardening rather than an observed fix

@madelinevibes madelinevibes added this to the v26.09 milestone Jul 31, 2026
@daywalker90

Copy link
Copy Markdown
Collaborator

I think this fix is more appropriate #9423. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants