Skip to content

Search Manage Tokens by contract address - #6170

Open
j0ntz wants to merge 1 commit into
developfrom
jon/manage-tokens-contract-search
Open

Search Manage Tokens by contract address#6170
j0ntz wants to merge 1 commit into
developfrom
jon/manage-tokens-contract-search

Conversation

@j0ntz

@j0ntz j0ntz commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Description

Manage Tokens search only matched a token's currency code and display name, so pasting a contract address returned no results even though the Assets search finds the same token by that address. The token filter now also matches the token's networkLocation values (ie. contractAddress), the same rule the wallet list and create-wallet list searches already use.

The filter moved out of the scene into a pure searchTokenIds helper so it can be unit tested; the existing "matches anywhere in the field" behavior for currency code and display name is unchanged.

Asana: https://app.asana.com/0/1215088146871429/1217587221308437

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

@j0ntz

j0ntz commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

📸🪓 Test evidence (iOS sim, Manage Tokens contract-address search)

🪓 Hack-forced evidence: DevTestScene temporarily rendered ManageTokensScene directly, because navigate('manageTokens') is a silent no-op under maestro on this debug build (reproduced on unmodified develop); the scene, its token data, the search field and the filter are all real, and the edit was reverted. Temporary uncommitted edit, reverted before commit; the marked frames prove the rendering, not the trigger.

🪓 HACK-FORCED: before fix full mog address no results

🪓 HACK-FORCED: before fix full mog address no results

🪓 HACK-FORCED: after fix full mog address finds mog

🪓 HACK-FORCED: after fix full mog address finds mog

🪓 HACK-FORCED: after fix full shib address finds shib

🪓 HACK-FORCED: after fix full shib address finds shib

🪓 HACK-FORCED: search by code mog still works

🪓 HACK-FORCED: search by code mog still works

Captured by the agent's in-app test run (build-and-test).

The Manage Tokens search only matched a token's currency code and display
name, so pasting a contract address returned nothing even though the
Assets search finds the same token. Match the token's networkLocation
values too, the same way the wallet list and create-wallet list searches
already do.
@j0ntz
j0ntz marked this pull request as ready for review August 21, 2026 06:28
@j0ntz
j0ntz force-pushed the jon/manage-tokens-contract-search branch from 5b0ae27 to a33ca9f Compare August 21, 2026 06:28
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant