Apply custom token additions on Manage Tokens save - #6169
Open
j0ntz wants to merge 4 commits into
Open
Conversation
Contributor
Author
j0ntz
marked this pull request as ready for review
August 21, 2026 05:03
j0ntz
force-pushed
the
jon/manage-tokens-custom-add
branch
from
August 21, 2026 05:03
ef6b5a1 to
d07fc19
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Description
Adding a custom token from Manage Tokens left the screen in two wrong states:
the outer Save stayed greyed out unless a default token had also been toggled,
and the new token did not join the enabled tokens at the top of the list. It was
only findable by searching for it by name.
Both came from the deferred-save state added in "Add deferred save to
ManageTokensScene":
pendingEnabledTokenIdsand tobaselineSet, so the addition nevercounted as an unsaved change and the Save button stayed disabled.
sortingBaselineSetwas auseMemowith empty deps, frozen at mount, so atoken that appeared later sorted with the disabled tokens.
The fix defers the enable to the Manage Tokens Save button, which is what the
task asks for:
EditTokenScenetakes adeferEnableparam. When set, and only for abrand-new custom token, it creates the token and leaves the enable to the
caller. The other entry points (wallet list, scan, create-wallet) do not pass
it and keep enabling immediately.
ManageTokensScenepassesdeferEnable, spots the new custom token id, andputs it in the pending set and the sorting baseline. The outer Save then
applies it, and it renders with the enabled tokens at the top.
they show up at the top too instead of only through a name search.
testIDs were added to the wallet list rows and the Manage Tokens rows so themaestro flow could target them; the wallet rows had no stable selector and their
accessibility strings are whole-row concatenations.
Asana: https://app.asana.com/0/1215088146871429/1217694458639427
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have: