Skip to content

Remove duplicate Jenkins push trigger - #6166

Open
JP0P wants to merge 1 commit into
developfrom
codex/remove-duplicate-jenkins-trigger
Open

Remove duplicate Jenkins push trigger#6166
JP0P wants to merge 1 commit into
developfrom
codex/remove-duplicate-jenkins-trigger

Conversation

@JP0P

@JP0P JP0P commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Remove the redundant githubPush() trigger from the multibranch Jenkins pipeline.

Why

GitHub Branch Source already schedules builds for branch pushes. Keeping githubPush() enabled adds a second scheduling path for the same webhook, which can build the same application revision twice and create duplicate downstream artifacts and tests.

This has been observed in production: builds #160 and #161 both built commit 7795512. During validation, Jenkins also attempted to queue a second testMaestro build while #166 was already running.

Risk

Low. The final diff only removes three lines of Jenkins trigger configuration.

  • GitHub Branch Source continues handling push builds.
  • The periodic multibranch scan remains available for missed webhook events.
  • Manual builds and disableConcurrentBuilds() remain unchanged.
  • No application, build, artifact, test, deployment, or retry logic changes.

Both trigger mechanisms use Jenkins' /github-webhook/ endpoint, so githubPush() is not an independent delivery fallback. Any duplicate or missing webhook-delivery investigation is separate from removing this redundant scheduling path.

Validation

  • After the updated Jenkinsfile ran, the child job no longer persisted GitHubPushTrigger.
  • The one duplicate seen during the transition was expected because the child initially processed that push with its previously persisted trigger configuration.
  • The current testMaestro job configuration contains no generic GitHub push trigger.
  • CI and security checks pass.

The transition behavior does not recur after a child has loaded the updated Jenkinsfile.

@JP0P
JP0P marked this pull request as draft August 19, 2026 02:27
@JP0P
JP0P force-pushed the codex/remove-duplicate-jenkins-trigger branch from b7f1ba3 to 5cc6634 Compare August 19, 2026 21:07
@JP0P
JP0P marked this pull request as ready for review August 19, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant