Update the Coinhub buy and sell menus by j0ntz · Pull Request #6165 · EdgeApp/edge-react-gui

j0ntz · 2026-08-19T01:03:43Z

Description

Coinhub buy/sell changes requested by the Coinhub team, plus the app-name
question they raised.

Asana: https://app.asana.com/0/1215088146871429/1216998636347236

Coinhub now runs the ramps buy/sell flow like every other build. The
useLegacyBuySell shim that pinned it to GuiPluginListScene is gone, and the
partner destinations are ramp plugins instead of buyPluginListOverride.json
rows.

New ramp plugins (src/plugins/ramps/coinhub/), all built on the existing
createExternalRampPlugin factory:

Plugin	Direction	Payment type	Destination
`coinhubatm`	buy + sell	cash	`coinhubbitcoinwallet.app/buy-atms`, `/sell-atms` (in-app WebView)
`coinhubexchange`	buy + sell	wire	`coinhubexchange.com` (device browser)
`coinhubfunded`	buy	wire	`coinhubfunded.com` (device browser)

coinhubfunded is what replaces the originally-requested "Trade" bottom-tab
button, per the 2026-08-19 note on the task: "we will not add a new 'trade'
button to the menu option but will instead add the CoinHub-funded site into the
buy menu."

MoonPay ACH sell needs no new code and no info-server change on the ramps
side: moonpayRampPlugin already quotes ach in both directions, and ramps
reads rampQuoteFilter, not the legacy fiatPluginPriority document that
EdgeApp/edge-info-server#162
was opened to fix. That PR is no longer a dependency of this one.

Supporting changes

createExternalRampPlugin gains two things these plugins need: it hands the
URI to the device browser when the backing GuiPlugin sets externalBrowser
(composed by the existing makePluginUri, so baseQuery, deepQuery,
lockUriPath and queryPromoCode behave as they do for the WebView), and
cryptoAssets is now optional, since an ATM takes whatever the customer
brings.
Ramp plugins that hold no credentials load without a RAMP_PLUGIN_INITS
entry.
AppConfig.rampPluginIds lets a white-label build name the providers it sells
through. Coinhub lists its own three plus moonpay, which is exactly what the
info server already allowed the app under fiatPluginPriority.
The edge://plugin/<id> deep-link path honors externalBrowser, so those
links no longer hand a full third-party site the EdgeProvider wallet bridge.
Plain-tap rejections in the legacy list scene now reach the region-aware error
handler, which previously ran only on long-press.

The legacy buyPluginListOverride.json / sellPluginListOverride.json rows stay
as they are. pluginListBuyOld / pluginListSellOld are still registered and
reachable from DevTestScene, and Coinhub's own rows are what should render
there rather than Edge's default list.

App name. iOS PRODUCT_NAME and the Android app_name resource already read
Coinhub Wallet; only coinhubConfig.ts still said Coinhub Bitcoin Wallet, so
the in-app copy now matches the home-screen name. The App Store / Play Store
listing titles are console fields, not code, and the bundle id
app.coinhubatm.wallet is permanent.

Base is coinhub, which was first rebased onto develop (94 commits, base was
2026-07-21) at the operator's direction.

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

Yes
No

The CHANGELOG tracks user-facing edge-app changes; this is white-label Coinhub
configuration on a branch that never merges to develop.

Dependencies

None. The Coinhub build box needs a RAMP_PLUGIN_INITS.moonpay entry in its
env.json for the MoonPay quotes (the legacy PLUGIN_API_KEYS.moonpay key the
old flow used is not read by the ramp plugin); the three Coinhub plugins need no
credentials.

Requirements

If you have made any visual changes to the GUI. Make sure you have:

Tested on iOS device
Tested on Android device
Tested on small-screen device (iPod Touch)
Tested on large-screen device (tablet)

j0ntz · 2026-08-19T01:04:41Z

📸 Test evidence

buy menu teller removed

buy menu scrolled

exchange opens browser

funded opens browser

sell menu ach and exchange

ach no provider toast

app name coinhub wallet

Captured by the agent's in-app test run (build-and-test).

chatgpt-codex-connector · 2026-08-19T01:05:37Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

j0ntz · 2026-08-19T01:12:45Z

📸 Test evidence (after fix)

exchange opens browser after fix

Captured by the agent's in-app test run (build-and-test).

cursor

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit a66f964. Configure here.}

j0ntz · 2026-08-19T01:23:26Z

📸 Test evidence (deep-link fix)

deeplink opens browser

Captured by the agent's in-app test run (build-and-test).

The legacy buy/sell list could only launch a row into the in-app WebView or a native fiat plugin. Rows that point at a whole partner website rather than an embedded purchase flow belong in the device browser, so add an `externalBrowser` flag to `GuiPlugin` and hand those rows to `openBrowserUri`.

Removes the Bitcoin Teller buy row, adds Coinhub Exchange / OTC bank-wire rows to both menus and a Coinhub Funded row to the buy menu, all of which open in the device browser, and restores the ACH sell row so MoonPay and the other ACH providers can quote a sell.

The iOS `PRODUCT_NAME` and the Android `app_name` resource already read Coinhub Wallet, so the config strings behind every in-app mention were the only place still saying Coinhub Bitcoin Wallet.

Only the long-press path forwarded rejections to the region-aware error handler, so a plain tap that failed (a payment method with no available provider, an unopenable partner URL) left the user on the list with no feedback at all.

A partner-website plugin reached over `edge://plugin/<id>` still pushed the EdgeProvider WebView, which both contradicts the row's stated behavior and hands a full third-party site the wallet bridge.

j0ntz · 2026-08-19T01:28:51Z

📸 Test evidence (makePluginUri fix)

row tap after makepluginuri

deeplink funded after makepluginuri

Captured by the agent's in-app test run (build-and-test).

j0ntz · 2026-08-19T01:40:42Z

📸 Test evidence (MoonPay ACH sell quote, with the info-server fix served locally)

sell asset picker moonpay assets

moonpay ach sell quote

Captured by the agent's in-app test run (build-and-test).

Coinhub's ATM network, exchange/OTC desk and Funded prop-trading site become external ramp plugins so the app can retire the legacy buy/sell list. The external ramp factory gains two things they need: a device-browser launch for partner destinations that are whole websites of their own, and an optional crypto asset list, since a cash ATM takes whatever the customer brings. These carry no credentials, so they load without a RAMP_PLUGIN_INITS entry, and an app config can now name the ramp plugins it sells through.

The buy and sell tabs now open the ramp create scenes like every other build, so the legacy scene shim and its useLegacyBuySell config flag come out. Coinhub sells through its own three destinations plus MoonPay, which is what the info server already allowed the app under the legacy plugin priority.

claude

Claude Code Review

Claude Code Review is paused for this repository. To reconnect it, an admin of this repository's GitHub organization (or the account owner, for personal repositories) who can also manage your Claude organization's Code Review settings needs to re-link GitHub in Code Review settings. This is a one-time step.

_{Tip: disable this comment in your organization's Code Review settings.}

j0ntz · 2026-08-21T00:38:32Z

📸 Test evidence (ramps migration)

buy quotes coinhub providers

coinhub exchange browser

coinhub funded browser

coinhub atm webview

moonpay ach sell quote

sell quotes coinhub providers

coinhub atm sell webview

Captured by the agent's in-app test run (build-and-test).

j0ntz marked this pull request as ready for review August 19, 2026 01:05

j0ntz force-pushed the jon/coinhub-buy-menu-updates branch from 4d88472 to 8651c18 Compare August 19, 2026 01:05

cursor Bot reviewed Aug 19, 2026

View reviewed changes

Comment thread src/components/scenes/GuiPluginListScene.tsx

j0ntz force-pushed the jon/coinhub-buy-menu-updates branch from 8651c18 to fd233e1 Compare August 19, 2026 01:12

cursor Bot reviewed Aug 19, 2026

View reviewed changes

Comment thread src/constants/plugins/GuiPlugins.ts

cursor Bot reviewed Aug 19, 2026

View reviewed changes

Comment thread src/actions/DeepLinkingActions.tsx

j0ntz added 5 commits August 18, 2026 18:24

Use Coinhub Wallet as the in-app name

1f03cb8

The iOS `PRODUCT_NAME` and the Android `app_name` resource already read Coinhub Wallet, so the config strings behind every in-app mention were the only place still saying Coinhub Bitcoin Wallet.

Surface errors from a buy/sell plugin row tap

3969910

Only the long-press path forwarded rejections to the region-aware error handler, so a plain tap that failed (a payment method with no available provider, an unopenable partner URL) left the user on the list with no feedback at all.

Honor externalBrowser on plugin deep links

9f5201d

A partner-website plugin reached over `edge://plugin/<id>` still pushed the EdgeProvider WebView, which both contradicts the row's stated behavior and hands a full third-party site the wallet bridge.

j0ntz force-pushed the jon/coinhub-buy-menu-updates branch from a66f964 to 9f5201d Compare August 19, 2026 01:25

j0ntz added 2 commits August 20, 2026 17:37

claude Bot reviewed Aug 21, 2026

View reviewed changes

Navigation Menu

Uh oh!

Update the Coinhub buy and sell menus - #6165

Update the Coinhub buy and sell menus#6165
j0ntz wants to merge 7 commits into
coinhubfrom
jon/coinhub-buy-menu-updates

j0ntz commented Aug 19, 2026 •

edited

Loading

Uh oh!

j0ntz commented Aug 19, 2026

Uh oh!

chatgpt-codex-connector Bot commented Aug 19, 2026

Uh oh!

Uh oh!

j0ntz commented Aug 19, 2026

Uh oh!

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

j0ntz commented Aug 19, 2026

Uh oh!

j0ntz commented Aug 19, 2026

Uh oh!

j0ntz commented Aug 19, 2026

Uh oh!

claude Bot left a comment

Uh oh!

j0ntz commented Aug 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

j0ntz commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

CHANGELOG

Dependencies

Requirements

Uh oh!

j0ntz commented Aug 19, 2026

📸 Test evidence

Uh oh!

chatgpt-codex-connector Bot commented Aug 19, 2026

Uh oh!

Uh oh!

j0ntz commented Aug 19, 2026

📸 Test evidence (after fix)

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

j0ntz commented Aug 19, 2026

📸 Test evidence (deep-link fix)

Uh oh!

j0ntz commented Aug 19, 2026

📸 Test evidence (makePluginUri fix)

Uh oh!

j0ntz commented Aug 19, 2026

📸 Test evidence (MoonPay ACH sell quote, with the info-server fix served locally)

Uh oh!

claude Bot left a comment

Choose a reason for hiding this comment

Claude Code Review

Uh oh!

j0ntz commented Aug 21, 2026

📸 Test evidence (ramps migration)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

j0ntz commented Aug 19, 2026 •

edited

Loading