fix(maestro): stabilize Graal state and C000045 - #6157
Conversation
c78ab02 to
d372862
Compare
d372862 to
7795512
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0da6fd1. Configure here.
| - tapOn: ".*Ethereum" | ||
| - tapOn: Next | ||
| - tapOn: | ||
| id: "createWalletRow.create-ethereum-ethereum" |
There was a problem hiding this comment.
Wrong Ethereum split row testID
High Severity
The new Ethereum split selector uses createWalletRow.create-ethereum-ethereum, but create-list keys are create-${walletType}-${pluginId}. Ethereum’s walletType is wallet:ethereum, so the real testID is createWalletRow.create-wallet:ethereum-ethereum. Maestro will not find the row, and C000037 fails before the split confirm.
Reviewed by Cursor Bugbot for commit 0da6fd1. Configure here.
The tag was C000029 but the flow is C000029a; a C000029a tag-filtered run silently skipped it. Match the tag to the test ID. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Superseded by #6172, the single direct-to-develop Maestro repair PR containing the Graal YAML change and all recent existing-flow fixes. |


Summary
output.*for GraalJS compatibility.ASSET_NAMESinputs at shared helper boundaries.Nextloop and fix iOS keyboard dismissal.Enter 2FA codewording while restoring selector-basedDeny,Deny All, andSKIPhandling.launch-cleared.Why
Maestro 2.7 uses GraalJS, where local variables and reassigned environment values do not persist into later commands. Several flows also depended on brittle selectors or stale UI text.
The coordinate taps were temporary diagnostics/workarounds, not maintainable test behavior. Current builds do not require the update-modal dismissal, and C190284 retains its text-selector fallback for the optional approval-list path.
Verification
maestro check-syntaxduring the original remediation.maestro/common/launch-cleared.yamlandmaestro/03-login/C190284-2fa-01.yamleach passmaestro check-syntax.git diff --checkpasses.maestro-testMaestrorelease4931, app4.50.2-testMaestro(26081916).0.Deny,Deny All, andSKIPwere absent and skipped as optional, so that branch remains unverified.Version undefinedvsVersion undefined-m); no snapshot or unrelated product files are included in these commits.Runtime evidence
testMaestrobuild26081916.Remaining limitations
Tracking
1217568524679355and1217568524499642.Publication state
This PR is intentionally kept as a Draft for GitHub backup and continued QA work. It is not being submitted for review or publication yet.