#2455 - Added hook for naming copied pivot tables during worksheet copy - #2457
Merged
Conversation
swmal
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a naming hook for pivot tables copied during a worksheet copy, mirroring the existing table copy hook. Also fixes a pre-existing bug in
ExcelPivotTable.Namethat this work surfaced.See #2455
Changes
Feature
ExcelPivotTableCopyEventArgs(SourceTableName,DefaultName,NewName).PivotTableCopyHandleronExcelWorksheetCopyOptions, invoked for each copied pivot table. The caller can setNewNameto rename the copy.CopyPivotTablenow returns its source→copy name map; anApplyPivotTableCopyOptionspass runs last inCopy, routing the rename through theExcelPivotTable.Namesetter so name uniqueness is validated.GETPIVOTDATAis address based, so no formula adjustment is needed.Bug fix
ExcelPivotTable.Namevalidated and bookkept against the table collection (_tableNames/ExistsTableName) — a copy-paste fromExcelTable. Corrected to the pivot collection (_pivotTableNames/ExistsPivotTableName). The copy constructor no longer sets the name via the setter, avoiding a double registration in_pivotTableNames.Tests
Added coverage in
CopyWorksheetTestsfor default generated naming, the rename hook, source/default name context, nullNewName, name-collision rejection, andGETPIVOTDATAresolution after rename. ExistingPivotTableTests(range-copy path) remain green.