fix(kms): reject repeated onboarding - #930
Merged
Merged
Conversation
kvinwang
force-pushed
the
codex/fix-kms-repeated-onboarding
branch
from
July 31, 2026 03:15
6db5a47 to
308ad3a
Compare
kvinwang
changed the title
kvinwang
changed the base branch from
codex/fix-kms-bootstrap-once
to
codex/fix-kms-finish-response-order
July 31, 2026 03:15
kvinwang
force-pushed
the
codex/fix-kms-repeated-onboarding
branch
from
August 3, 2026 14:53
308ad3a to
cb9a01e
Compare
kvinwang
force-pushed
the
codex/fix-kms-repeated-onboarding
branch
from
August 3, 2026 16:39
cb9a01e to
22490ad
Compare
kvinwang
force-pushed
the
codex/fix-kms-repeated-onboarding
branch
from
August 3, 2026 16:57
22490ad to
9a25fff
Compare
kvinwang
force-pushed
the
codex/fix-kms-repeated-onboarding
branch
from
August 4, 2026 02:26
9a25fff to
dd852f2
Compare
kvinwang
force-pushed
the
codex/fix-kms-repeated-onboarding
branch
from
August 5, 2026 01:43
dd852f2 to
865c50e
Compare
kvinwang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After successful KMS onboarding, the onboarding RPC remained usable. A repeated or concurrent request could replace identity state that must remain stable after initialization.
Fix
Serialize onboarding with the existing bootstrap lock and reject onboarding when either persisted KMS identity key already exists.
The branch is rebuilt on current
master. The gracefulFinishshutdown behavior is already provided by #875 and is no longer part of this PR's delta. The unrelated globalra-rpcJSON response normalization has been removed.Verification
cargo fmt --manifest-path dstack/Cargo.toml --allcargo check --manifest-path dstack/Cargo.toml -p dstack-kmscargo test --manifest-path dstack/Cargo.toml -p dstack-kms --no-rungit diff --check