Skip to content

FEE 871 Mapping claims and evidence - #1247

Open
KarolaKirsanow wants to merge 10 commits into
DiscourseGraphs:mainfrom
KarolaKirsanow:mapping-claims
Open

FEE 871 Mapping claims and evidence#1247
KarolaKirsanow wants to merge 10 commits into
DiscourseGraphs:mainfrom
KarolaKirsanow:mapping-claims

Conversation

@KarolaKirsanow

Copy link
Copy Markdown
Contributor

This adds a short article to obsidian/fundamentals called "Mapping claims and evidence" as suggested by our SEO analysis. The article can be copied to roam/fundamentals; it has no platform-specific content

@KarolaKirsanow KarolaKirsanow self-assigned this Jul 24, 2026
@KarolaKirsanow KarolaKirsanow added the documentation Improvements or additions to documentation label Jul 24, 2026
@vercel

vercel Bot commented Jul 24, 2026

Copy link
Copy Markdown

@KarolaKirsanow is attempting to deploy a commit to the Discourse Graphs Team on Vercel.

A member of the Team first needs to authorize it.

@KarolaKirsanow
KarolaKirsanow marked this pull request as ready for review August 6, 2026 20:27
@graphite-app

graphite-app Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

PR size/scope check

This PR is over our review-size guideline.

  • Recommended: ~200 lines changed
  • Acceptable limit: up to 400 lines when well-scoped/self-contained
  • Preferred file count: fewer than 5 files

Please split this into smaller PRs unless there is a clear reason the changes need to land together.

If keeping it as one PR, please add a brief justification covering:

  • What single problem this PR solves
  • Why the files/changes are coupled

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 1 additional finding in Devin Review.

Open in Devin Review

Comment on lines +1 to +6
---
title: "Mapping claims and evidence"
date: "2026-07-23"
author: ""
published: true
---

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 New documentation page uses the wrong file extension for a plain-text article

The new article is saved as an MDX file (apps/website/content/obsidian/fundamentals/mapping-claims-and-evidence.mdx) even though it contains only plain prose and images, while the project's documentation rules reserve MDX for pages that use components.
Impact: The page deviates from the documented file-naming convention for docs, making the content tree inconsistent.

Convention source and file contents

skills/update-user-docs/references/doc-conventions.md states: "Use .md for normal prose pages and .mdx only when the page needs components." The new page contains only headings, paragraphs and image links — no NodeTag, Callout, or other MDX components — so it should be mapping-claims-and-evidence.md, with the _meta.ts slug unchanged (apps/website/content/obsidian/fundamentals/_meta.ts:6). Note the sibling prose page in the same directory is base-grammar.md.

Prompt for agents
The new docs page apps/website/content/obsidian/fundamentals/mapping-claims-and-evidence.mdx contains only prose and image links, with no MDX components. Repository docs conventions (skills/update-user-docs/references/doc-conventions.md) require .md for prose pages and .mdx only when components are used; the sibling page base-grammar.md follows this. Rename the file to .md; the _meta.ts entry uses the slug so it needs no change.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Comment thread apps/website/content/obsidian/fundamentals/mapping-claims-and-evidence.mdx Outdated
@KarolaKirsanow
KarolaKirsanow marked this pull request as draft August 6, 2026 20:34
@KarolaKirsanow
KarolaKirsanow marked this pull request as ready for review August 6, 2026 20:39
@KarolaKirsanow

Copy link
Copy Markdown
Contributor Author

request a read from @joelchan and/or @jsmorabito for content.

@jsmorabito jsmorabito left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! Approved 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants