Report PowerShell 5.x module operation failures instead of success - #5309
Merged
Gabriel Dufresne (GabrielDuf) merged 1 commit intoAug 21, 2026
Merged
Conversation
Copilot started reviewing on behalf of
Gabriel Dufresne (GabrielDuf)
August 21, 2026 13:19
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Improves PowerShell 5.x package operations so non-terminating errors produce failure exit codes.
Changes:
- Captures cmdlet errors using a standardized error variable.
- Exits with code 1 when captured errors exist.
- Adds coverage for all operation types and custom error-variable handling.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/UniGetUI.PackageEngine.Managers.PowerShell/Helpers/PowerShellPkgOperationHelper.cs |
Adds error capture and exit-code propagation. |
src/UniGetUI.PackageEngine.Tests/PowerShellManagerTests.cs |
Tests error propagation and custom parameter behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Marc-André Moreau (mamoreau-devolutions)
approved these changes
Aug 21, 2026
Gabriel Dufresne (GabrielDuf)
deleted the
fix/5251-powershell-silent-update-failure
branch
August 21, 2026 20:01
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves error handling in PowerShell package operations by ensuring that non-terminating errors are properly propagated to the exit code, unless the user explicitly overrides error variable handling. It also adds comprehensive tests to verify this behavior.
PowerShell error handling improvements:
ErrorVariableNametoPowerShellPkgOperationHelperto standardize the error variable used for capturing errors.PowerShellPkgOperationHelperto automatically add-ErrorVariableand an exit code check (;if($ErrorVariableName){exit(1)}) unless custom error variable parameters are supplied by the user.Testing enhancements: