Skip to content

Scheduler: Multilevel grouping — Fix aria-required-parent in vertical group panel - #34648

Merged
aleksei-semikozov merged 1 commit into
feature/scheduler-multilevel-grouping/mainfrom
feature/scheduler-multilevel-grouping/fix-a11y-vertical-group-panel
Aug 5, 2026
Merged

Scheduler: Multilevel grouping — Fix aria-required-parent in vertical group panel#34648
aleksei-semikozov merged 1 commit into
feature/scheduler-multilevel-grouping/mainfrom
feature/scheduler-multilevel-grouping/fix-a11y-vertical-group-panel

Conversation

@aleksei-semikozov

Copy link
Copy Markdown
Contributor

No description provided.

@aleksei-semikozov aleksei-semikozov self-assigned this Aug 4, 2026
@aleksei-semikozov
aleksei-semikozov force-pushed the feature/scheduler-multilevel-grouping/fix-a11y-vertical-group-panel branch from c4aea7d to 2600696 Compare August 4, 2026 14:24
@aleksei-semikozov
aleksei-semikozov marked this pull request as ready for review August 4, 2026 15:04
@aleksei-semikozov
aleksei-semikozov requested a review from a team as a code owner August 4, 2026 15:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes an accessibility issue in the Scheduler’s vertical group panel (multilevel grouping) by removing an ARIA role that triggers aria-required-parent violations, and expands automated a11y coverage for grouped Scheduler configurations.

Changes:

  • Removed role="rowheader" from the vertical group panel node cell to avoid invalid ARIA role hierarchy.
  • Updated Jest unit tests to reflect the removed role and explicitly assert it is not present.
  • Added TestCafe a11y (axe) coverage for grouped Scheduler scenarios across multiple views/orientations, including hierarchical resources.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/devextreme/js/__internal/scheduler/r1/components/base/group_panel_vertical_node.tsx Removes invalid rowheader role from group panel cell markup to address axe aria-required-parent.
packages/devextreme/js/__internal/scheduler/r1/components/base/group_panel_vertical_node.test.tsx Aligns unit expectations with the updated markup and adds an explicit assertion that role is not set.
e2e/testcafe-devextreme/tests/accessibility/scheduler/scheduler.ts Adds axe checks for Scheduler grouping scenarios across multiple views/orientations and resource hierarchies.

Comment thread e2e/testcafe-devextreme/tests/accessibility/scheduler/scheduler.ts Outdated
@aleksei-semikozov
aleksei-semikozov force-pushed the feature/scheduler-multilevel-grouping/fix-a11y-vertical-group-panel branch 2 times, most recently from 536b8fa to f2b7146 Compare August 5, 2026 11:19
@aleksei-semikozov
aleksei-semikozov force-pushed the feature/scheduler-multilevel-grouping/fix-a11y-vertical-group-panel branch from f2b7146 to 3ee5db2 Compare August 5, 2026 11:56
@aleksei-semikozov
aleksei-semikozov merged commit 6bd80da into feature/scheduler-multilevel-grouping/main Aug 5, 2026
96 of 98 checks passed
@aleksei-semikozov
aleksei-semikozov deleted the feature/scheduler-multilevel-grouping/fix-a11y-vertical-group-panel branch August 5, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants